Drop dependency on StringIO #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StringIO was extracted as a gem, so spring can no longer use it for the same reason it can't use the `json` gem. Otherwise you'll see warnings like: ``` ...stringio.bundle: warning: already initialized constant StringIO::VERSION ``` This can be reproduced on Ruby 3.0, by installing `stringio 3.0.1` and starting a Rails app with spring.
casperisfine
commented
Nov 24, 2021
| @@ -46,8 +46,6 @@ def self.dump(data) | |||
|
|
|||
| # See https://github.com/kr/okjson for updates. | |||
There was a problem hiding this comment.
The upstream repo is archived so I think it's no big deal to modify it.
Also I wonder why Marshal wasn't used in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringIO was extracted as a gem, so spring can no
longer use it for the same reason it can't use the
jsongem.
Otherwise you'll see warnings like:
This can be reproduced on Ruby 3.0, by installing
stringio 3.0.1and starting a Rails app with spring.
cc @rafaelfranca