Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutex_m to runtime dependency #700

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

koic
Copy link
Contributor

@koic koic commented Aug 15, 2023

This PR adds mutex_m to runtime dependency to suppress the following Ruby 3.3's warning:

$ ruby -v
ruby 3.3.0dev (2023-08-03T00:11:08Z master 4b6c584023) [x86_64-darwin22]

$ spring start
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/spring-4.1.1/lib/spring/watcher/abstract.rb:2:
warning: mutex_m which is not part of the default gems since Ruby 3.4.0

Related PR ... rails/rails#48907

This PR adds `mutex_m` to runtime dependency to suppress the following Ruby 3.3's warning:

```console
$ ruby -v
ruby 3.3.0dev (2023-08-03T00:11:08Z master 4b6c584023) [x86_64-darwin22]

$ spring start
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/spring-4.1.1/lib/spring/watcher/abstract.rb:2:
warning: mutex_m which is not part of the default gems since Ruby 3.4.0
```

Related PR ... rails/rails#48907
@koic koic force-pushed the add_mutex_m_to_runtime_dependency branch from 807e3e6 to 0ab29e5 Compare August 15, 2023 08:43
@rafaelfranca rafaelfranca merged commit 6b2001f into rails:main Aug 22, 2023
16 checks passed
@koic koic deleted the add_mutex_m_to_runtime_dependency branch August 22, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants