Clarify how to run Tailwind command in CI #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To simplify the message, should we just recommend one way to do it, and that's: ? |
|
Yes, that's much better. |
|
I tweaked the language a tiny bit. Can you take a look and let me know if you think we should make any more changes? |
Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
ghiculescu
commented
Dec 7, 2022
|
Just one suggestion. I hope that rails/rails#46664 will make all this irrelevant! Thanks for your help @flavorjones |
Co-authored-by: Alex Ghiculescu <alex@tanda.co>
|
Thanks for diving into the Rails tasks, I had just started down that path. homer-disappearing-into-a-bush.gif |
Well I haven't quite got it working right, see my comment on the PR. Help is welcome!! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current docs are a bit confusing, because only
raketasks get enhanced by this library, but there's alsorailstasks that look the same.I tried to make it a bit more clear.
Disclaimer: it's possible I've gotten confused and there's a much simpler recommended approach... I'd love for that to be true!