Change CLASS_NAME_PATTERN to work also for haml templates #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wnm
force-pushed
the
new-class-name-regex-for-haml
branch
from
26aa897 to
083f851
Compare
|
Let's link this to #31, I almost got started on this not realizing you made moves already. Also, thanks for tackling it. ❤️ |
|
ugh, sorry about that I totally forgot to mention this PR in a comment in #31. I don't think I have the permission to link the issue as well... |
|
@wnm, do you think this will also work for slim templates? I would be happy using haml, but inherited a project that uses slim... |
|
yes, it should work, at least for the default configuration which is using the same syntax for class names as haml, e.g: |
|
Happy to see this adapted to the new purger. |
wnm
force-pushed
the
new-class-name-regex-for-haml
branch
from
9f9cdda to
e2786d7
Compare
|
@dhh done! I also added tests for slim syntax. it has a similar syntax (the same regex works), but better tailwind support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the CLASS_NAME_PATTERN to work for haml templates.
Since haml syntax uses dots to chain class names, I first removed the dot from the search pattern...
But, to make sure it still works for decimal spacing classes (e.g.
my-1.5), I added a pattern to allow dots which are preceded by a number between 0-3 and followed by a 5.By looking through the tailwind documentation, I think all the different class patterns are covered by a test already, so I'm not sure how to improve the test coverage... I'm happy to add more tests, but would need some input first, on what to test for...