Handle both rails 7.2 and rails 8.0 field types for checkbox/textarea #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They got renamed in: * rails/rails#52432 * rails/rails#52467 This ensures the correct classes are generated for both old and new versions
|
Good job @Earlopain yes I created rails 8.0.0.beta1 |
skipkayhil
approved these changes
Oct 10, 2024
|
@Earlopain Thank you for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #416
They got renamed (with aliases being present) in:
text_areatotextareaandrich_text_areatorich_textarearails#52467This ensures the correct classes are generated for both old and new versions. I added a test locally but it can only assert against the exact css classes since there is nothing else to properly distinquish them. I can add this here if you wish, just didn't seem like the best test.
@enderahmetyurt, I suspect you generated your sample app with rails 8.0.0.beta1 which is why it looked weird for you.