-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TravisCI: removed Ruby versions < 2.3 since rubygems deprecated them #643
TravisCI: removed Ruby versions < 2.3 since rubygems deprecated them #643
Conversation
alessio-signorini
commented
Dec 30, 2018
Where can I read more about this removal? Thor still support Ruby < 2.3 so we need to test on them in some way |
@rafaelfranca, the log I attached above is the output of Rubygems v3.0+ require Ruby >= 2.3. Here is a link to the issue on their Github. Ruby 2.3 was released in 2015. |
Right. An easier fix is to change the |
@rafaelfranca that's an idea. I looked at this link but could not find an easy way to do it. Do you know how? Do you mind creating a PR for that? How do we know the Ruby versions that need to be supported by Thor? |
As far as I understand each ruby installation includes a version of rubygems. Even the latest Ruby |
Maybe we can actually drop support instead. Thor's main dependants, Rails and Bundler, have already moved on, so maybe it's time? |
@deivid-rodriguez That sounds like a drastic step. I do use thor in my project called tty and I'm keen for this library to support Ruby |
My take to this is to follow the upstream policy, so when ruby-core drops support for a version of ruby, I drop support too. But this is up to the maintainers to decide :) |
I'm up to remove support of older version on thor 1.0 but right now I'd prefer a green build in all the versions we support today. |
So that means that the next version will not yet be 1.0, or at least that you haven't yet decided it... Right? |
What about for dropping support for rubies under 2.0, @rafaelfranca? Would you be willing to merge that now if I open a PR? |