Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use config.web_console.allowed_ips #291

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Use config.web_console.allowed_ips #291

merged 1 commit into from
Jun 10, 2020

Conversation

JuanitoFatas
Copy link

This PR updates references of old term. Deprecate the old usage.

After this PR, we can update debugging rails guide‘s web_console setting.

@gsamokovarov
Copy link
Collaborator

Thank you! ❤️

@gsamokovarov gsamokovarov merged commit d5f289d into rails:master Jun 10, 2020
@JuanitoFatas JuanitoFatas mentioned this pull request Jun 10, 2020
Merged
@JuanitoFatas JuanitoFatas deleted the config_allowed_ips branch June 10, 2020 09:50
@p8
Copy link
Member

p8 commented Jun 18, 2020 •
edited
Loading

Sorry for the Bikeshed 😄, but now we used both permitted and allowed, but they have the same meaning.
For example:

web-console/lib/web_console/permissions.rb

Lines 7 to 8 in 02f51e1

# IPv4 and IPv6 localhost should be always allowed.
ALWAYS_PERMITTED_NETWORKS = %w( 127.0.0.0/8 ::1 )

Or:

web-console/test/web_console/request_test.rb

Line 23 in 02f51e1

test "#permitted? is truthy for allowed IPs via allowed proxies" do

Should we replace allowed with permitted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuanitoFatas @gsamokovarov @p8