Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent deprecation warnings by removing template formats #298

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Prevent deprecation warnings by removing template formats #298

merged 1 commit into from
Aug 19, 2020

Conversation

mikelkew
Copy link

Using . when specifying template names has been deprecated, and shows many warning when running the test suite.

Removing the format from the name when specifying the templates to render resolves this issue, whilst keeping existing functionality.

@mikelkew
Prevent warnings by removing template formats
a61dd15 
Using `.` when specifying template names has been deprecated, and
shows many warning when running the test suite.

Removing the format from the name when specifying the templates
to render resolves this issue.
@gsamokovarov
Copy link
Collaborator

Thanks for taking the time to fix those issues! 🙇

@gsamokovarov gsamokovarov merged commit eeaf847 into rails:master Aug 19, 2020
mishina2228 added a commit to mishina2228/web-console that referenced this pull request Jun 8, 2022
@mishina2228
Render templates without '.' in the name
0222015 
Similar change as rails#298

refs:
- rails/rails#39164
- https://stackoverflow.com/questions/68836670/rails-6-1-4-deprecation-warning-rendering-actions-with
mishina2228 added a commit to mishina2228/web-console that referenced this pull request Jun 8, 2022
@mishina2228
Render templates without '.' in the name
62e6db3 
Similar change as rails#298

refs:
- rails/rails#39164
- https://stackoverflow.com/questions/68836670/rails-6-1-4-deprecation-warning-rendering-actions-with
mishina2228 added a commit to mishina2228/web-console that referenced this pull request Jun 9, 2022
@mishina2228
Render templates without '.' in the name
5af8b65 
Similar change as rails#298

refs:
- rails/rails#39164
- https://stackoverflow.com/questions/68836670/rails-6-1-4-deprecation-warning-rendering-actions-with
@mishina2228 mishina2228 mentioned this pull request Jun 9, 2022
Merged
patrickm68 added a commit to patrickm68/web-console that referenced this pull request Dec 1, 2022
@patrickm68
Render templates without '.' in the name
78702f1 
Similar change as rails/web-console#298

refs:
- rails/rails#39164
- https://stackoverflow.com/questions/68836670/rails-6-1-4-deprecation-warning-rendering-actions-with
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikelkew @gsamokovarov