node_modules should no longer be compiled by default

[jakeNiemiec]

node_modules will no longer be compiled by default. This primarily fixes rails issue #35501 as well as numerous other webpacker issues. The disabled loader can still be required explicitly via:

const nodeModules = require('@rails/webpacker/rules/node_modules.js')
environment.loaders.append('nodeModules', nodeModules)

If you have added environment.loaders.delete('nodeModules') to your environment.js, this must be removed or you will receive an error (Item nodeModules not found).

fixes rails/rails#35501
fixes #2131
fixes rails/rails#36278
fixes #2407
fixes #2114
fixes #1949
fixes #1865
fixes #1857

[javan]

Have you confirmed that this fixes compiling JS for a fresh Rails 6 app (e.g. rails/rails#35501, rails/rails#36278)?

[jakeNiemiec]

Have you confirmed that this fixes compiling JS for a fresh Rails 6 app

@javan I have tested against these 3 cases and everything seems to work well.

@modusss rails/rails#36278 (comment)

@terracatta rails/rails#35501 (comment)

@ngottlieb #2131 (comment)

//cc @gauravtiwari

[javan]

🚢it

[maschwenk]

Can/should I close? https://github.com/rails/webpacker/pull/2075/files

[gauravtiwari]

Thanks @jakeNiemiec lets work out what else we need to get in the major 6.0.0 release.

[ximus]

@gauravtiwari Seems like the rules/node_modules mentioned here still needs to be added, not sure what its contents should be.

It's now documented in the changelog but absent in the tree. I couldn't find an issue tracking this