How to configure terser?

[will]

Sorry in advance this is long-winded. I don’t know enough about frontend stuff to know what is important and what isn't, so I'm including everything that I think might be relevant.

I'm (hopefully) at the very end of a long process of migrating from the umaintained-for-over-two-years webpack-rails to webpacker, and everything is so close, but I have one dependency that is breaking in production but not in development. It appears to be due to magnification or mangling or something like that. It seems like a project called terser is what is being used now, but I'm not 100% sure.

maybe just exclude this from minification?

I'd be more than happy to exclude this file form minification, rather than figure out which options of mangle or compress or minify etc is the actual cause.

I see from terser's documentation https://webpack.js.org/plugins/terser-webpack-plugin#exclude to exclude a file you add

module.exports = {
  optimization: {
    minimizer: [
      new TerserPlugin({
        exclude: /\/excludes/,
      }),
    ],
  },
};

to webpack.config.js. However, unlike webpack-rails, I don’t think webpacker uses webpack.config.js at all, and instead it's all in config/webpack/* and config/webpack.yml. That's okay, however I cant figure out how to get this configuration in there.

After doing the generate task to drop all the new files for webpacker, my producion.js is only

process.env.NODE_ENV = process.env.NODE_ENV || 'production'

const environment = require('./environment')

module.exports = environment.toWebpackConfig()

My environment.js is

const { environment } = require('@rails/webpacker')

const webpack = require('webpack');
environment.plugins.append("Provide", new webpack.ProvidePlugin({
  $: 'jquery',
  jQuery: 'jquery',
  'window.jQuery': 'jquery',
}));

module.exports = environment

I added some things in there to get jquery to work, but otherwise it's as it came from the generator.

I see that in this project's webpacker/package/environments/production.js there is a lot of terser configuration, however I haven't tracked down yet how or if that gets called.

I'm using webpacker-4.0.7 gem and "@rails/webpacker": "^4.0.7", npm.

the actual problem

The project that is breaking for me is metrics-graphics and terser (or whatever is doing the minification) is doing this:

development

production

[jakeNiemiec]

I think it might be babel and not terser. Babel/core-js is the one that polyfills things like typeof. Original source here.

Can you tell me if putting: environment.loaders.delete('nodeModules'); in your config/webpack/environment.js file fixes it? (put it right after const environment = require('./environment').

If that doesn't work, can you show me the context where you are importing metrics-graphics? Can you also give some more info on the files pictured?

[will]

@jakeNiemiec wow that fixed it. Thank you!! I put it in config/webpack/production.js instead of c/w/environment.js since I think that's what you meant. Is this good to just leave that way forever with removing the nodeModules loader?

I'm importing metrics-graphcis on a particular page, and the _typeof being undefined (well t after all the minification), was causing the component it was a part of to not be defined, so it couldn't be found with the ujs loader thing. The rest of the site would work, just not the page that imported metrics-graphics.

The pictures were the chrome debugger on that line that failed, I assume after all the source mapping, since the error messages didn't match up with the lines in the chrome debugger (t vs _typeof)

[jakeNiemiec]

instead of c/w/environment.js since I think that's what you meant

No, the problem is that you are re-transpiling code that has already been transpiled. I would future-proof things by putting it in environment, but you could probobly get away with not doing it.

Think about if you use Google Translate to pass a phrase through many different languages. In the same way, nuance is lost and the result you get can break depending on what you started with. From what I can tell, the typeof polyfill broke after being passed through a newer version of Babel.

Is everything working now, can this be closed?

[will]

Ah okay, I see what you're saying. I wasn't aware that node_modules would already be transpiled at all.

I thought you meant production because that file has const environment = require('./environment'). whereas environment has a similar, but slightly different line const { environment } = require('@rails/webpacker'). I'll move it to the second line of environment.

Thank you for your help!

[swrobel]

I'm still curious how to configure Terser. I previously configured UglifyJS to strip console statements like so:

const uglifyOptions = environment.plugins.get('UglifyJs').options.uglifyOptions;

uglifyOptions.compress.drop_console = true; // Remove console statements

but it seems the configuration completely changed in Webpacker 4 and so Terser (and before it, Uglify) is no longer available via environment.plugins. cc: @gauravtiwari

related: #1235 (comment)

[jakeNiemiec]

You could try playing around with environment.config.optimization.minimizer....

Here is where this is set (drop_console would be set under compress):

webpacker/package/environments/production.js

Lines 42 to 60 in 9e671a3

	terserOptions: {
	parse: {
	// Let terser parse ecma 8 code but always output
	// ES5 compliant code for older browsers
	ecma: 8
	},
	compress: {
	ecma: 5,
	warnings: false,
	comparisons: false
	},
	mangle: {
	safari10: true
	},
	output: {
	ecma: 5,
	comments: false,
	ascii_only: true
	}

[swrobel]

@jakeNiemiec thanks for getting me on the right path! This worked:

environment.config.optimization.minimizer.find(m => m.constructor.name === 'TerserPlugin').options.terserOptions.compress.drop_console = true

[ngottlieb]

@jakeNiemiec I've run into what is more or less the same problem trying to use mapbox gl js with a relatively vanilla rails 6 webpacker setup (here's a related issue on the Mapbox repo). Your recommendation --

environment.loaders.delete('nodeModules');

solved the problem, but it seems like a blunt instrument. I'm new to webpacker, but shouldn't default behavior transpile modules that need it and ignore ones that don't? Or, perhaps ignore all of them, like you're suggesting?

EDIT I changed it to just exclude mapbox-gl here, but it still seems like an open question as to whether or not this is really the best solution?

[jakeNiemiec]

@ngottlieb @swrobel Glad to see you got it working.

it seems like a blunt instrument. I'm new to webpacker, but shouldn't default behavior transpile modules that need it and ignore ones that don't?

The inclusion of the nodeModules loader (which transpiles node_modules) is not a clear-cut topic; it can break things depending on what dependencies the user is using. For mapbox-gl, it has already been packed twice by the time it gets to node_modules. This problem usually arises when code is transpiled, then minified, then transpiled & minified again by webpacker.

This results in a kind of fidelity loss where included global polyfills, like _typeof, are overwritten by the global _typeof that webpacker provides. You can see this happening in Will's pictures above.

---

it still seems like an open question as to whether or not this is really the best solution?

I can't think of a scenario where not transpiling nodeModules would cause an error. I guess there is the concern that changing it will suddenly break things for folks who now rely on the current nodeModules loader behavior.

One helpful change that we could make would be to move the "Excluding node_modules From Being Transpiled By Babel-Loader" section from the upgrade doc to the readme doc since it is often required outside of upgrading from v3 to v4.

---

@gauravtiwari @javan @dhh What do you think? I feel like I have seen this issue enough times over the past year to warrant some discussion on the pain points it causes. Webpack 5 is already on the horizon, webpacker@5 could take advantage of the semver major release to address this problem as a breaking change.

Here are some earmarked examples from the past year since the webpacker@4 release where the nodeModules loader causes problems (newest to oldest):

• Active Storage with Direct Upload js giving syntax error  rails#36278 (comment)
• Active Storage with Direct Upload js giving syntax error  rails#36278 (comment)
• Actioncable Webpacker compilation issues with Rails 6 in production rails#35501 (comment)
• Issues using react-diagrams node module #2407 (comment)
• [4.0.6] using webpack-dev-server in fresh rails app results in Uncaught TypeError #2114 (comment)
• Uncaught TypeError: __webpack_require__(...) is not a function - error on fresh app #2109 (comment)
• Importing npm package causes error when compiling asserts in Webpack 4.x. Works just fine in Webpacker 3.x #1949 (comment)
• CKEditor 5 build #1865 (comment)
• [4.0.0.rc.1 / 4.0.0.rc.2] Doesn't allow non-transpiled JS. #1857 (comment)