Improved output on webpack error #3241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
reviewed
Nov 30, 2021
lib/webpacker/compiler.rb
Outdated
| @@ -89,7 +89,7 @@ def run_webpack | |||
| end | |||
| else | |||
| non_empty_streams = [stdout, stderr].delete_if(&:empty?) | |||
| logger.error "Compilation failed:\n#{non_empty_streams.join("\n\n")}" | |||
| logger.error "Compilation failed:\n ExitStatus: #{status}\n Outputs: #{non_empty_streams.join("\n\n")}" | |||
There was a problem hiding this comment.
I think we can make this even a bit more obvious.
Can you try adding a \n before the non_empty_streams part, as your example shows it's hard to see how the messages are grouped by the indenting?
There was a problem hiding this comment.
We can add a blank line before this and make all caps.
Compilation failed:
There was a problem hiding this comment.
@justin808 Thanks for the comment.
The following is the result of the modification ( 5900430 , 354af2a ).
Does the output meet your requirements?
** Execute webpacker:compile
Compiling...
COMPILATION FAILED:
EXIT STATUS: pid 414 SIGTERM (signal 15)
OUTPUTS:
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
|
@guillaumebriday this one looks good to merge. Safe change. @pocari Thanks for the contribution! Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When webpack terminates with an error, the reason may not be clear from the stdout and stderr output alone.
For example, I could not understand the reason when webpack was killed. (See the
beforeoutput below).For this reason, when webpack fails, it outputs the status information in addition to the stdout and stderr output. Now, I can notice when webpack is killed. (See the
afteroutput below).output examples
before:
after: