-
-
Notifications
You must be signed in to change notification settings - Fork 28
Add more data to the compats table #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add more data to the compats table #125
Conversation
1. `rake data:update_rails_releases` | ||
2. `Gemmies::Create.call('rack')` | ||
3. After that you can visit `http://localhost:3000/gems/rack` and you can see the info. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We do not necessarily need to add this, but also maybe the correct title is
local setup
. - I would keep the
step 1
because when you set up locally, we need those Rails releases.step 2 and 3
are not necessary, given that they can be done by UI.
maximum_ruby_version: "3.4.2", | ||
minimum_bundler_version: "2.5.20", | ||
maximum_bundler_version: "2.5.20", | ||
minimum_rubygems_version: "3.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etagwerker can you share with me the current Production values for Rails 8
? I'll copy paste here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mateusdeap, I have doubts because on this file, for Rails 7.2, we have, for example:
minimum_bundler_version: "2.5.20"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I mean, to me that means we need to find out why that version was set that way. Did you try looking at the commit history?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mateusdeap I got the feeling that it was set up directly in the Production Rails console. So here we have an opportunity to:
- Add it to the script so when we set it up locally, we have the same scenario as production.
- Validate those minimum/maximum values that were set up here for Rails 7.2 and Rails
Seems that we updated it one year ago so far, but maybe it was a workaround given that we don't do too many things related to it currently (FWIU)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what you mean by "set up directly in the Production Rails console". I'm referring to why that file was written to say the minimum bundler version compatible is 2.5.20 rather than what we have in our blog post.
I saw that you were the one to add this file last year, @etagwerker. Do you remember?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At any rate, @julioalucero, I think this is beyond the scope of this PR, so maybe you just replicate what we have for Rails 7.2 just making sure to replace 3.4.2 for 3.4.7 which is the latest release for ruby and I think there is also a newer release of ruby gems but I'm not sure what version it is. I'll approve the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds more data to the compats table in order to resolve this issue #118.
compact.id
was added in the first column.Rails Release
was added in the third column.We can move if we prefer.
Seed Data
I added a section to the Readme called
seed data
to help with local setup that is outside of the original issue's scope.In parallel, I added Rails 8 to the list of Rails Releases