Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp isn't defined in ./lib/utils/bozon.js #21

Closed
alerdenisov opened this issue Aug 3, 2016 · 5 comments
Closed

gulp isn't defined in ./lib/utils/bozon.js #21

alerdenisov opened this issue Aug 3, 2016 · 5 comments
Labels

Comments

@alerdenisov
Copy link

Missing requirement of gulp module in ./lib/utils/bozon.js

@alchaplinsky
Copy link
Collaborator

Is it present in ./node_modules in your project directory?

@alerdenisov
Copy link
Author

I mean you're using gulp variable without define it..
https://github.com/railsware/bozon/blob/master/lib/utils/bozon.js#L28

@klevinlaughs
Copy link

The requireLocal function returns a required instance of gulp. The function is defined it on line 37 of that file. Then he proceeds to use that instance.

@eriedl
Copy link

eriedl commented Aug 29, 2016

that is so not correct. while the apply function expects a "this argument", it cannot be inferred from the context it's called on. apply applies to functions not objects.
Lines 27 and 34 would have to look something like this:
return this.requireLocal('gulp').task.apply(this.requireLocal('gulp'), Array.prototype.slice.call(arguments, 1))
OR
var gulp = this.requireLocal('gulp') return gulp.task.apply(gulp, Array.prototype.slice.call(arguments, 1))

eriedl pushed a commit to eriedl/bozon that referenced this issue Aug 30, 2016
@alchaplinsky
Copy link
Collaborator

Use version v0.5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants