Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State dump modifications #5382

Merged
merged 7 commits into from Mar 21, 2024
Merged

State dump modifications #5382

merged 7 commits into from Mar 21, 2024

Conversation

benisgold
Copy link
Member

Fixes APP-####

What changed (plus any additional context for devs)

  • added wallet connect v2 sessions data to state dump
  • made some changes to json serialization, namely to deal with the many circular references in redux state. currently we flatten all the state data which makes it super illegible

Screen recordings / screenshots

What to test

@nickbytes
Copy link
Contributor

@benisgold this is a month old, are we going to merge this or should we scrap?

Copy link
Contributor

@dereknelson dereknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we ball

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/flatted@3.2.7

View full report↗︎

@benisgold benisgold merged commit 824c210 into develop Mar 21, 2024
6 checks passed
@benisgold benisgold deleted the @benisgold/statedump branch March 21, 2024 22:47
BrodyHughes added a commit that referenced this pull request Apr 2, 2024
* 'develop' of github.com:rainbow-me/rainbow:
  Bump Rudderstack version to v1.12.1 (#5556)
  txs: detail sheet updates (#5535)
  browser: requests background color (#5562)
  fix: hide favs on non mainnet assets (#5565)
  balances: fetch twice tx confirm (#5551)
  [CHORE]: Remove Apollo client in favor of `@/graphql` (#5555)
  browser: favorites state + menu (#5553)
  init browser state (#5552)
  Dapp Browser: Search UI (#5542)
  Dapp Browser + provider (#5543)
  NFT offers/mints gas estimation improvements (#5448)
  State dump modifications (#5382)
  fix crash (#5544)
  [SWAPS V2]: Adjust asset types + utils to match BX (#5538)
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants