Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT offers/mints gas estimation improvements #5448

Merged
merged 7 commits into from Mar 21, 2024
Merged

NFT offers/mints gas estimation improvements #5448

merged 7 commits into from Mar 21, 2024

Conversation

benisgold
Copy link
Member

@benisgold benisgold commented Mar 1, 2024 •
edited

Fixes APP-####

What changed (plus any additional context for devs)

Used tx simulation to improve gas estimation for nft offers and mints:

  • nft offers: tx simulation estimation -> static reservoir estimation -> internal hardcoded fallback
  • mints: tx simulation
  • super jank fix for gas issue that causes old gas estimation to persist. this caused the gas button to sometimes display completely incorrect gas.

outstanding bugs:

  • APP-1206 100% of the time, sale tx fails when acceptOffer requires an approval before the sale. so far only tested on Base/Zora.
  • APP-1207 need to remove gas button from mints if we cant mint w/ reservoir, bc we don't have the tx data from reservoir to calcualte gas
  • APP-1208 for some mints, buyToken fails during gas estimation for unknown reason, 400 error code. so far only seen on Zora
  • APP-1182 infinite render bug, p sure it only happens if accepting an nft offer fails

Screen recordings / screenshots

What to test

@benisgold benisgold changed the title NFT offers gas estimation improvements NFT offers/mints gas estimation improvements Mar 5, 2024
skylarbarrera
skylarbarrera approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benisgold benisgold merged commit c5ce968 into develop Mar 21, 2024
6 checks passed
@benisgold benisgold deleted the @benisgold/simulate-offer branch March 21, 2024 22:48
BrodyHughes added a commit that referenced this pull request Apr 2, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into develop
97c83ef 
* 'develop' of github.com:rainbow-me/rainbow:
  Bump Rudderstack version to v1.12.1 (#5556)
  txs: detail sheet updates (#5535)
  browser: requests background color (#5562)
  fix: hide favs on non mainnet assets (#5565)
  balances: fetch twice tx confirm (#5551)
  [CHORE]: Remove Apollo client in favor of `@/graphql` (#5555)
  browser: favorites state + menu (#5553)
  init browser state (#5552)
  Dapp Browser: Search UI (#5542)
  Dapp Browser + provider (#5543)
  NFT offers/mints gas estimation improvements (#5448)
  State dump modifications (#5382)
  fix crash (#5544)
  [SWAPS V2]: Adjust asset types + utils to match BX (#5538)
This was referenced Apr 2, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylarbarrera skylarbarrera skylarbarrera approved these changes

@walmat walmat Awaiting requested review from walmat

@dereknelson dereknelson Awaiting requested review from dereknelson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benisgold @skylarbarrera