[SWAPS V2]: Adjust asset types + utils to match BX #5538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
requested review from
brunobar79,
skylarbarrera and
benisgold
as code owners
skylarbarrera
approved these changes
Mar 20, 2024
| volume1d: number; | ||
| }; | ||
|
|
||
| export type UniqueId = `${Address}_${ChainId}`; |
There was a problem hiding this comment.
getting war flashbacks here, kind of a nbd if contained to swaps but testy about having too patterns here
| @@ -0,0 +1,347 @@ | |||
| import { AddressZero } from '@ethersproject/constants'; | |||
There was a problem hiding this comment.
this is all cool rn but were gonna need to merge with our current parsers/utils at some point or things are going to get real confusing
dereknelson
approved these changes
Mar 20, 2024
skylarbarrera
approved these changes
Mar 21, 2024
| }; | ||
|
|
||
| export const deriveChainIdByHostname = (hostname: string) => { | ||
| switch (hostname) { |
There was a problem hiding this comment.
just putting it on record that this the kinda shit that i hate 😤
There was a problem hiding this comment.
agreed. luckily think we can refactor this away pretty easily
BrodyHughes
added a commit
that referenced
this pull request
Apr 2, 2024
* 'develop' of github.com:rainbow-me/rainbow: Bump Rudderstack version to v1.12.1 (#5556) txs: detail sheet updates (#5535) browser: requests background color (#5562) fix: hide favs on non mainnet assets (#5565) balances: fetch twice tx confirm (#5551) [CHORE]: Remove Apollo client in favor of `@/graphql` (#5555) browser: favorites state + menu (#5553) init browser state (#5552) Dapp Browser: Search UI (#5542) Dapp Browser + provider (#5543) NFT offers/mints gas estimation improvements (#5448) State dump modifications (#5382) fix crash (#5544) [SWAPS V2]: Adjust asset types + utils to match BX (#5538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test