balances: fetch twice tx confirm #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we could use the timestamp of the most recent query update to conditionally do this fetch? Otherwise it seems like we might end up with redundant fetches but idk |
|
I actually think we should refetch on interval here until the change has been detected. |
|
@benisgold there's not really a good way to confirm that the balances have been updated properly , this is p inexpensive so nbd imo @walmat i see what you're saying but 👆 we should be able to check onchain balances and update that way for txs like swaps where we know what assets are coming in and out this is more of a patch for the time being to ensure data is updated as quick as possible |
walmat
approved these changes
Mar 26, 2024
BrodyHughes
added a commit
that referenced
this pull request
Apr 2, 2024
* 'develop' of github.com:rainbow-me/rainbow: Bump Rudderstack version to v1.12.1 (#5556) txs: detail sheet updates (#5535) browser: requests background color (#5562) fix: hide favs on non mainnet assets (#5565) balances: fetch twice tx confirm (#5551) [CHORE]: Remove Apollo client in favor of `@/graphql` (#5555) browser: favorites state + menu (#5553) init browser state (#5552) Dapp Browser: Search UI (#5542) Dapp Browser + provider (#5543) NFT offers/mints gas estimation improvements (#5448) State dump modifications (#5382) fix crash (#5544) [SWAPS V2]: Adjust asset types + utils to match BX (#5538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1274
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test