Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide favs on non mainnet assets #5565

Merged
merged 1 commit into from Mar 27, 2024
Merged

Conversation

skylarbarrera
Copy link
Contributor

Fixes APP-1273

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

@walmat
Copy link
Contributor

walmat commented Mar 27, 2024

I think we should rework favorites to be multi-chain instead of doing this

@skylarbarrera skylarbarrera merged commit ad7aaf5 into develop Mar 27, 2024
6 checks passed
@skylarbarrera skylarbarrera deleted the @skylar/hide-fav-on-l2 branch March 27, 2024 16:38
BrodyHughes added a commit that referenced this pull request Apr 2, 2024
* 'develop' of github.com:rainbow-me/rainbow:
  Bump Rudderstack version to v1.12.1 (#5556)
  txs: detail sheet updates (#5535)
  browser: requests background color (#5562)
  fix: hide favs on non mainnet assets (#5565)
  balances: fetch twice tx confirm (#5551)
  [CHORE]: Remove Apollo client in favor of `@/graphql` (#5555)
  browser: favorites state + menu (#5553)
  init browser state (#5552)
  Dapp Browser: Search UI (#5542)
  Dapp Browser + provider (#5543)
  NFT offers/mints gas estimation improvements (#5448)
  State dump modifications (#5382)
  fix crash (#5544)
  [SWAPS V2]: Adjust asset types + utils to match BX (#5538)
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants