Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP-1370]: bump sentry sdk to latest #5640

Merged
merged 2 commits into from Apr 18, 2024
Merged

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Apr 18, 2024

Fixes APP-1370

What changed (plus any additional context for devs)

Bumped sentry sdk to latest

context to what this fixes: https://rainbowhaus.slack.com/archives/C0468CDBE75/p1713454106026279

Screen recordings / screenshots

What to test

Copy link

linear bot commented Apr 18, 2024

@nickbytes
Copy link
Contributor

Haven't read any release notes on these two major versions yet, did you find anything that might cause perf/breaking changes @walmat ?

Copy link

socket-security bot commented Apr 18, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sentry/react-native@5.22.0 Transitive: environment, filesystem, network, shell +19 80.8 MB sentry-bot

🚮 Removed packages: npm/@sentry/cli@1.77.3, npm/@sentry/react-native@3.4.1

View full report↗︎

Copy link

socket-security bot commented Apr 18, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/@sentry/cli@2.30.4
  • Install script: postinstall
  • Source: node ./scripts/install.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@sentry/cli@2.30.4

Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so behind, nice

@walmat
Copy link
Contributor Author

walmat commented Apr 18, 2024

Haven't read any release notes on these two major versions yet, did you find anything that might cause perf/breaking changes @walmat ?

none other than a few typing changes

@skylarbarrera skylarbarrera merged commit ba8e6dd into develop Apr 18, 2024
4 of 6 checks passed
@skylarbarrera skylarbarrera deleted the @matthew/APP-1370 branch April 18, 2024 19:36
BrodyHughes added a commit that referenced this pull request Apr 18, 2024
…eplink-add

* 'develop' of github.com:rainbow-me/rainbow: (23 commits)
  Add SmoothPager (#5641)
  [APP-1370]: bump sentry sdk to latest (#5640)
  Browser refactor (#5638)
  bump version to v1.9.22 (#5634)
  Price Impact Warning (#5635)
  Disable welcome screen animations when IS_TESTING (#5637)
  init (#5495)
  [WIP]: Swaps v2 quote fetching (#5601)
  chore: app start up spring cleaning (#5622)
  fix remote config (#5627)
  would it kill you to log this only once (#5626)
  Recents (#5625)
  wc: improvements (#5616)
  Degen chain support (#5621)
  send: check contract address (#5586)
  tx requests: metadata (#5584)
  audit: phin (#5624)
  Fix: Wallets being marked as backed up by walletLoadState() (#5593)
  NFTs: filter instead of throw error when NFT has invalid network (#5537)
  Dapp Browser: Search (#5617)
  ...
Copy link

sentry-io bot commented Apr 30, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **Error: consolidatedTransactionsQueryFunction: ** <global>(src/logger/index) View Issue
  • ‼️ Error: Branch: error when handling event <global>(src/logger/index) View Issue
  • ‼️ Error: NFT Mints: Gas Step Error: Balance too low to proceed with transaction (use skipBalanceCheck=true... <global>(src/logger/index) View Issue
  • ‼️ Error: Branch: error when handling event <global>(src/logger/index) View Issue
  • ‼️ **Error: fetchTransaction: ** <global>(src/logger/index) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants