Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable welcome screen animations when IS_TESTING #5637

Merged
merged 2 commits into from Apr 17, 2024
Merged

Disable welcome screen animations when IS_TESTING #5637

merged 2 commits into from Apr 17, 2024

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Apr 17, 2024 •
edited

What changed (plus any additional context for devs)

  • I built with IS_TESTING=false and the screen worked fine
  • I built with flag on and animations were gone
  • can confirm this is not the behavior on current develop
  • this change is what fixed CI-8 i believe

skylarbarrera
skylarbarrera approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems chill brodee

@BrodyHughes BrodyHughes merged commit 98d30c2 into develop Apr 17, 2024
6 checks passed
@BrodyHughes BrodyHughes deleted the brody/disable-welcome-animations branch April 17, 2024 22:10
BrodyHughes added a commit that referenced this pull request Apr 18, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/de…
304fc80 
…eplink-add

* 'develop' of github.com:rainbow-me/rainbow: (23 commits)
  Add SmoothPager (#5641)
  [APP-1370]: bump sentry sdk to latest (#5640)
  Browser refactor (#5638)
  bump version to v1.9.22 (#5634)
  Price Impact Warning (#5635)
  Disable welcome screen animations when IS_TESTING (#5637)
  init (#5495)
  [WIP]: Swaps v2 quote fetching (#5601)
  chore: app start up spring cleaning (#5622)
  fix remote config (#5627)
  would it kill you to log this only once (#5626)
  Recents (#5625)
  wc: improvements (#5616)
  Degen chain support (#5621)
  send: check contract address (#5586)
  tx requests: metadata (#5584)
  audit: phin (#5624)
  Fix: Wallets being marked as backed up by walletLoadState() (#5593)
  NFTs: filter instead of throw error when NFT has invalid network (#5537)
  Dapp Browser: Search (#5617)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylarbarrera skylarbarrera skylarbarrera approved these changes

@walmat walmat Awaiting requested review from walmat

@benisgold benisgold Awaiting requested review from benisgold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BrodyHughes @skylarbarrera