Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSS filter buttons to update independently #20

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

rajbos
Copy link
Owner

@rajbos rajbos commented May 21, 2024

Closes #19

Implements independent updates for RSS filter buttons based on their exact text content.

  • Adds a data-feed-name attribute to each filter button to store the exact feed name, ensuring that updates to button text are based on an exact match rather than using includes.
  • Modifies the button text update logic to utilize the data-feed-name attribute for identifying the correct button to update, resolving the issue of incorrect updates when feed names share a common prefix.
  • Updates the filterNews function to use the data-feed-name attribute for filtering news items, allowing for precise selection based on the feed name.

For more details, open the Copilot Workspace session.

@rajbos rajbos merged commit 2041445 into main May 21, 2024
@rajbos rajbos deleted the fix-rss-filter branch May 21, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSS filter buttons are the same for two different feeds
1 participant