“make check” errors

[veryfoolish]

Trying to compile latest version (i.e., commit d5be349)…

make[2]: Entering directory `/home/ryan/code/torrent/libtorrent/test'
if g++ -DHAVE_CONFIG_H -I. -I. -I.. -I. -I.. -I../src    -g -O2 -g -DDEBUG -fvisibility=hidden -I/usr/kerberos/include   -I/usr/include/sigc++-2.0 -I/usr/lib64/sigc++-2.0/include   -MT LibTorrentTest-allocators_test.o -MD -MP -MF ".deps/LibTorrentTest-allocators_test.Tpo" -c -o LibTorrentTest-allocators_test.o `test -f 'rak/allocators_test.cc' || echo './'`rak/allocators_test.cc; \
    then mv -f ".deps/LibTorrentTest-allocators_test.Tpo" ".deps/LibTorrentTest-allocators_test.Po"; else rm -f ".deps/LibTorrentTest-allocators_test.Tpo"; exit 1; fi
In file included from rak/allocators_test.cc:5:
rak/allocators_test.h:1:45: error: cppunit/extensions/HelperMacros.h: No such file or directory
rak/allocators_test.h:7: error: ‘CppUnit’ has not been declared
rak/allocators_test.h:7: error: expected `{' before ‘TestFixture’
rak/allocators_test.h:7: error: invalid function declaration
rak/allocators_test.cc:7: error: expected constructor, destructor, or type conversion before ‘;’ token
rak/allocators_test.cc:15: error: invalid use of undefined type ‘class AllocatorsTest’
rak/allocators_test.h:7: error: forward declaration of ‘class AllocatorsTest’
rak/allocators_test.cc: In member function ‘void AllocatorsTest::testAlignment()’:
rak/allocators_test.cc:16: error: ‘aligned_vector_type’ was not declared in this scope
rak/allocators_test.cc:16: error: expected `;' before ‘v1’
rak/allocators_test.cc:17: error: expected `;' before ‘v2’
rak/allocators_test.cc:18: error: expected `;' before ‘v3’
rak/allocators_test.cc:19: error: expected `;' before ‘v4’
rak/allocators_test.cc:20: error: expected `;' before ‘v5’
rak/allocators_test.cc:22: error: ‘v1’ was not declared in this scope
rak/allocators_test.cc:22: error: ‘CPPUNIT_ASSERT’ was not declared in this scope
rak/allocators_test.cc:23: error: ‘v2’ was not declared in this scope
rak/allocators_test.cc:24: error: ‘v3’ was not declared in this scope
rak/allocators_test.cc:25: error: ‘v4’ was not declared in this scope
rak/allocators_test.cc:26: error: ‘v5’ was not declared in this scope
make[2]: *** [LibTorrentTest-allocators_test.o] Error 1
make[2]: Leaving directory `/home/ryan/code/torrent/libtorrent/test'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/home/ryan/code/torrent/libtorrent/test'
make: *** [check-recursive] Error 1

[rakshasa]

And no mention at all of your cppunit install?

At least show that you made a bit of effort to solve the issue.

[veryfoolish]

Okay, so I’m not a C++ developer and I didn’t realize that CPPUnit was a requirement of your software. To note, you might want to add it to the config script if it’s required to build the program according to the direction you give in ``INSTALL''.

I was submitting this bug out of kindness; the hostility isn’t appreciated. But thanks.

[veryfoolish]

And finally after running reset && ./configure && make && make check I get:

make[2]: Leaving directory `/home/ryan/code/torrent/libtorrent/test'
make  check-TESTS
make[2]: Entering directory `/home/ryan/code/torrent/libtorrent/test'
.....F...................................................F.
1 0
.............................

extents_test.cc:55:Assertion
Test name: ExtentsTest::test_basic
assertion failed
- Expression: verify_extent_data(extent_1, idx_empty, val_empty)

tracker_controller_test.cc:590:Assertion
Test name: tracker_controller_test::test_requesting_basic
assertion failed
- Expression: "10000"[1] == '1' || !tracker_0_1->is_busy()

Failures !!!
Run: 86   Failure total: 2   Failures: 2   Errors: 0
FAIL: LibTorrentTest
=================================
1 of 1 tests failed
Please report to jaris@ifi.uio.no
=================================
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory `/home/ryan/code/torrent/libtorrent/test'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/home/ryan/code/torrent/libtorrent/test'
make: *** [check-recursive] Error 1

[rakshasa]

That's the difference between a bug tracker and user support, and showing some effort at figuring out the issue is a curtesy to the developers.

Also CPPUNIT is not a requirement for installing the software, only for testing.

[veryfoolish]

You misspelled “courtesy” and I am not doing this for my health; there’s something wrong with your software. Perhaps you should address than rather than spending all of your energy being a total dick.

To wit, there’s still a flaw with your software and after CPPUNIT is installed it still fails. And according to the instructions you give in INSTALL you’re meant to run `make check``.