Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation issue with gcc v6.x and empty CXXFLAGS #156

Merged
merged 2 commits into from
Jun 5, 2018

Conversation

chros73
Copy link

@chros73 chros73 commented Jul 30, 2017

Fix compilation issue with gcc v6.x and empty CXXFLAGS:

  • it removes -O2 flag and compilation can fail (e.g. with make -j4)

Note: CFLAGS are also effected.

Closes: #155
Refers to: rakshasa/rtorrent#628

Edit:
I have updated the fix:

  • let the building environment (autotools) define what flags are used only if CFLAGS/CXXFLAGS is empty

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 18.02% when pulling c2b119d on chros73:fix_cxxflags_check into c167c5a on rakshasa:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 18.043% when pulling 8229218 on chros73:fix_cxxflags_check into c167c5a on rakshasa:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken compilation with gcc v6.x if CXXFLAGS env var is set
3 participants