Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase piece length max #165

Merged
merged 1 commit into from
Jun 9, 2019
Merged

Increase piece length max #165

merged 1 commit into from
Jun 9, 2019

Conversation

adambarta
Copy link

Still within INT_MAX could go to 24 AFAIK

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 18.043% when pulling 11c4d64 on adambarta:master into c167c5a on rakshasa:master.

@rakshasa
Copy link
Owner

The chunk size limit is there as a sanity check, 128mb chunks aren't sane. Are there really people out there using these sizes?

@adambarta
Copy link
Author

adambarta commented Jun 12, 2018 via email

@MarkRose
Copy link

MarkRose commented Sep 23, 2018

Here's a 2509 GB torrent that ends up having 40155 chunks because it's using only 64MB chunks. The torrent file is nearly 1MB.

@rakshasa rakshasa merged commit 11c4d64 into rakshasa:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants