Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roast depends on Rakudo when it shouldn't #640

Closed
niner opened this issue May 10, 2020 · 6 comments · Fixed by #641 or #642
Closed

Roast depends on Rakudo when it shouldn't #640

niner opened this issue May 10, 2020 · 6 comments · Fixed by #641 or #642
Assignees

Comments

@niner
Copy link
Contributor

niner commented May 10, 2020

Checking out roast and running perl fudgeandrun $(sed 's/#.*//' spectest.data | grep '\.t') using the system wide installed rakudo master yields the following test failures:

[ 1809s] Test Summary Report
[ 1809s] -------------------
[ 1809s] S03-metaops/misc.t                                       (Wstat: 256 Tests: 0 Failed: 0)
[ 1809s]   Non-zero exit status: 1
[ 1809s]   Parse errors: No plan found in TAP output
[ 1809s] S26-documentation/block-leading-user-format.t            (Wstat: 256 Tests: 0 Failed: 0)
[ 1809s]   Non-zero exit status: 1
[ 1809s]   Parse errors: No plan found in TAP output
[ 1809s] integration/advent2010-day03.t                           (Wstat: 512 Tests: 2 Failed: 2)
[ 1809s]   Failed tests:  1-2
[ 1809s]   Non-zero exit status: 2
[ 1809s]   Parse errors: Bad plan.  You planned 12 tests but ran 2.
[ 1809s] Files=1361, Tests=188669, 1777 wallclock secs (24.89 usr  2.58 sys + 2077.74 cusr 109.43 csys = 2214.64 CPU)
[ 1809s] Result: FAIL

S03-metaops/misc.t and S26-documentation/block-leading-user-format.t fail because they try to load a module called Test::Helpers which seems to be part of rakudo's tests. integration/advent2010-day03.t fails because it expects the files Makefile CREDITS LICENSE README.md which are clearly part of rakudo and not roast.

This is blocking automated spectests for every rakudo commit on the Open Build Service.

@niner
Copy link
Contributor Author

niner commented May 10, 2020

S03-metaops/misc.t was easy to fix. Done so in commit c2666ff

@JJ
Copy link
Contributor

JJ commented May 10, 2020

From Test::Helpers apparently what's used is is-run. Could probably be ported to the file itself, since it's not used from anywhere else. Let me try that.

JJ added a commit to JJ/roast that referenced this issue May 10, 2020
By putting it in here. Closes Raku#640.
tbrowder pushed a commit that referenced this issue May 10, 2020
By putting it in here. Closes #640.
@JJ JJ reopened this May 10, 2020
@JJ
Copy link
Contributor

JJ commented May 10, 2020

Reopening because there are still problems with integration/advent2010-day03.t Sorry about that.

@JJ
Copy link
Contributor

JJ commented May 10, 2020

This last one is probably redundant, since it's actually testing dir, which is tested elsewhere. Optionally, we can simply test other files.

JJ added a commit to JJ/roast that referenced this issue May 10, 2020
And this one really closes Raku#640
@niner
Copy link
Contributor Author

niner commented May 10, 2020 via email

@ugexe
Copy link
Contributor

ugexe commented May 10, 2020

Yes and no. Roast contains a Test::Helpers distribution but that's an entirely
different thing from the Test::Helpers module in Rakudo's t/lib

Ah. Then sounds like they should use

proto sub is_run(|) is export { * }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants