Adding fix for 'Investigate power (CW) appearing on rx only ports #228' #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dor#228' this adds sending the selected ANT1-3 bits through the High Priority Packet. New SDR firmware will use this to decide which ANT to select BEFORE going into TX. Older SDR firmware will still operate the same selecting the ANT after going to TX.
|
I have another update for this PR, I'll get that in tomorrow. I intended on copying all |
|
That should do it. |
|
cheers Rick, no time to do any testing here unfortunately at the moment, but have merged this |
|
Hi everyone
I’ve committed the new G2 firmware and P2app. These now correctly take the TX antenna from the new data bits in the protocol 2 high priority message, and RX antenna from the pre-existing bytes.
Tested with this temporary version of Thetis, that sets the new TX antenna bits.
When used with legacy version of Thetis, p2app detects that no TX bits are set and uses the “old” antenna bits (which at start of TX will begin on the RX setting, then change over).
I haven’t tested with the CW keyer yet but the message is being correctly decoded and processed through into the new firmware.
So from both an Orion mk 2 and Saturn perspective, the “CW leakage into RX antenna” should now be resolved.
Laurence Barker G8NJJ
***@***.***
From: Richie ***@***.***>
Sent: Wednesday, January 10, 2024 3:42 AM
To: ramdor/Thetis ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [ramdor/Thetis] Adding fix for 'Investigate power (CW) appearing on rx only ports #228' (PR #381)
cheers Rick, no time to do any testing here unfortunately at the moment, but have merged this
—
Reply to this email directly, view it on GitHub <#381 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEXTXZ54OIVEAKX27BIPULLYNYEYLAVCNFSM6AAAAABBRMIKM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBUGE2DCNZYGY> .
You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/AEXTXZYW3LPCXJ7YNGGLIOTYNYEYLA5CNFSM6AAAAABBRMIKM2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTQJW4NU.gif> Message ID: ***@***.*** ***@***.***> >
|
|
Committed it where? |
|
All the Saturn firmware and software is in my github repository:
github.com/laurencebarker/Saturn
Laurence Barker G8NJJ
***@***.***
From: Michael Black ***@***.***>
Sent: Wednesday, January 10, 2024 9:02 PM
To: ramdor/Thetis ***@***.***>
Cc: Laurence Barker ***@***.***>; Comment ***@***.***>
Subject: Re: [ramdor/Thetis] Adding fix for 'Investigate power (CW) appearing on rx only ports #228' (PR #381)
Committed it where?
—
Reply to this email directly, view it on GitHub <#381 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEXTXZ4TEEAGYR42UC5OEBTYN36TFAVCNFSM6AAAAABBRMIKM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVG4ZDINRTGY> .
You are receiving this because you commented. <https://github.com/notifications/beacon/AEXTXZ53DULWSIXWMR4MOPDYN36TFA5CNFSM6AAAAABBRMIKM2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTQMXP5Y.gif> Message ID: ***@***.*** ***@***.***> >
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds sending the selected ANT1-3 bits through the High Priority Packet. New SDR firmware will use this to decide which ANT to select BEFORE going into TX. Older SDR firmware will still operate the same selecting the ANT after going to TX.