Change Camera3DResource.cull_mask to use export_flags_3d_render #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenithStar
changed the title
ramokz
added a commit
that referenced
this pull request
Jun 1, 2024
* Move all spring arm initializaiton code out of _process into _ready (#282) * Move all spring arm initializaiton code out of _process into _ready. Resolves #193 * Making _follow_spring_arm explicitly top_level * Default _follow_spring_arm.position initialization to the original pcam position if follow_target is not available * Updated plugin.cfg to 0.7.1 * Change Camera3DResource.cull_mask to use export_flags_3d_render. Resolves #290 (#293) * Only show viewfinder if the active PCam's mode is framed (#295) * Only show viewfinder in the correct follow mode * Adjust comments * Reorder early returns * Remove unneeded type cast * Updated Editor Updater wording for major releases * Improved Limit Target error setter * Added FUNDING.yml * 2D Follow Physics Interpolation (#294) * Initial _process / _physics_process logic split * More 2d physics interpolation supported - [Added] Interpolation Update Mode to PCamHost - [Added] Additional warnings * Commented out 4.3 specific code * Stripped out a few todo comments * Removed uneeded checkers * Added physics body checker for Group Follow * Added reset_physics_interpolation - [Updated] Physics Interpolation to use string setters * Added physics target checker to PCam3D - [Moved] Follow Targets setters/getters closer to other Follow setters/getters * Aligned PCam2D' script with PCam3D's * Added missing variable assignment * Added missing return for Framed Follow checker * Removed unneeded boolean flag * Tidied up process logic * Added Jitter Tip output * Added physics checker to Look At Group * Updated parameter type from NodePath to Node3D * Updated spacing for setters/getter functions * Set _player_visual to top level in 2D example scene * Added additional jitter context * Updated append_look_at_targets_array * Added Godot 4.3 2D example scene variants --------- Co-authored-by: ZenithStar <ZenithStar@users.noreply.github.com> Co-authored-by: audeck <55060124+audeck@users.noreply.github.com>
ramokz
added a commit
that referenced
this pull request
Jun 3, 2024
* Move all spring arm initializaiton code out of _process into _ready (#282) * Move all spring arm initializaiton code out of _process into _ready. Resolves #193 * Making _follow_spring_arm explicitly top_level * Default _follow_spring_arm.position initialization to the original pcam position if follow_target is not available * Updated plugin.cfg to 0.7.1 * Change Camera3DResource.cull_mask to use export_flags_3d_render. Resolves #290 (#293) * Only show viewfinder if the active PCam's mode is framed (#295) * Only show viewfinder in the correct follow mode * Adjust comments * Reorder early returns * Remove unneeded type cast * Updated Editor Updater wording for major releases * Improved Limit Target error setter * Added FUNDING.yml * 2D Follow Physics Interpolation (#294) * Initial _process / _physics_process logic split * More 2d physics interpolation supported - [Added] Interpolation Update Mode to PCamHost - [Added] Additional warnings * Commented out 4.3 specific code * Stripped out a few todo comments * Removed uneeded checkers * Added physics body checker for Group Follow * Added reset_physics_interpolation - [Updated] Physics Interpolation to use string setters * Added physics target checker to PCam3D - [Moved] Follow Targets setters/getters closer to other Follow setters/getters * Aligned PCam2D' script with PCam3D's * Added missing variable assignment * Added missing return for Framed Follow checker * Removed unneeded boolean flag * Tidied up process logic * Added Jitter Tip output * Added physics checker to Look At Group * Updated parameter type from NodePath to Node3D * Updated spacing for setters/getter functions * Set _player_visual to top level in 2D example scene * Added additional jitter context * Phantom Camera Manager (#306) * Initial _process / _physics_process logic split * More 2d physics interpolation supported - [Added] Interpolation Update Mode to PCamHost - [Added] Additional warnings * Commented out 4.3 specific code * Stripped out a few todo comments * Removed uneeded checkers * Added physics body checker for Group Follow * Added reset_physics_interpolation - [Updated] Physics Interpolation to use string setters * Added physics target checker to PCam3D - [Moved] Follow Targets setters/getters closer to other Follow setters/getters * Aligned PCam2D' script with PCam3D's * Added missing variable assignment * Added missing return for Framed Follow checker * Removed unneeded boolean flag * Tidied up process logic * Added Phantom Camera Manager singleton * Minor fix for when not having a PCam in scene * Removed print statement * Fixed merge error * Removed unneeded print statement * Improved viewfinder detection (#307) * Added PCamHost warning when not child of Camera * Additional camera3d parameters (#308) * Added additional PhantomCamera3DResource properties * Shortened Camera3DResource local variable names * Updated Editor Updater to be less intrusive (#309) * Conditional checker for Cam3DRes changes * Added support for disable_3d export templates (#311) * Fixed viewfinder during play error * Minor tweaks * Minor post-main merge fix * Updated plugin.cfg to 0.7.2 * Resolved issue with disabled tween on load for Third Person Follow (#319) * Updated Third Person to update follow_position instead of global_position * Removed commented out code in PCamHost * Resolved issue with Follow Mode None getting stuck (#320) * Added public properties and getters for PCamManager * Updated git issue link --------- Co-authored-by: ZenithStar <ZenithStar@users.noreply.github.com> Co-authored-by: audeck <55060124+audeck@users.noreply.github.com>
ramokz
added a commit
that referenced
this pull request
Sep 9, 2024
* Added instance validator on _exit_tree() * First pass for 3D _validate_property() * Added additional 3D properties * Fixed jitter for none physics object (#179) * Update README.md * Added a checker for PCam Host when a PCam exits the scene (#175) * Fixed jitter for none physics object --------- Co-authored-by: Marcus Skov <Hello@MarcusSkov.com> * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * Updated viewfinder.gd * Minor property reference updates * Updated phantom_camera_3D.gd and phantom_camera_2D.gd * Updated plugin.cfg to 0.7 * Updated more properties and example scenes * Fixed issue with grabbing active_pcam in viewfinder.gd * Minor updates * 171 third person quaternion (#190) * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * Added quaternion setter/getter for Third Person Follow * Embedded enums to PCam3D script directly * Added additional doc comments * Updated 3D example scenes * Merged #191 into 0.7 * (Re)added draw limits variable to PCam2D * Updated script documentation * Added more properties and signals to PCam scripts - [Removed] Remaining constant. variable uses - [Added] dead_zone_changed signal - [Added] PhantomCameraHost variable to PCam scripts directly - [Updated] viewfinder.gd with the dead_zone_changed signal change - [Updated] pcam active setter in PCamHost using setter method * Added enums directly to tween_resource.gd - [Added] GDScript descriptions to tween resource properties * Changed assign_pcam_host to set_pcam_host * Updated .import files * Readded Host to Third Person Example scene * Updated example scenes * Fixed issue with Limit Margin not updating correctly * Updated Tween Resource enum names to align with Tween class * Removed phantom_camera_properties.gd * Swapped yaw and pitch variable names * Removed group_names.gd - [Moved] group_names.gd constants to phantom_camera_constants.gd * Updated example scenes * Added Cull Mask Helper Function - [Added] Setter / Getter for SpringArm3D shape and margin - [Renamed] Camera3DResource setter/getter names * Changed reset_limit_all_sides() to reset_limit() * Removed _camera_3D_resouce_default and tween_resource_default - [Renamed] spring_arm setters/getters - [Added] set_collision_mask_value helper function - [Added] Missing setters/getters * Fixed UI in 2D example scene * Removed tween_resource_default from PCam2D * Updated example scenes * Fixed issue with limit not working after a tween * Updated PCam Host setter/getter * Privitised has_tweened and has_multiple_follow_targets * Renamed pixel_perfect to snap_to_pixel * Added look_at_target_changed signal * Updated many script documentation comments * Added missing default values to phantom_camera scripts * Added comments and privatised variables and functions in phantom_camera_host.gd * Added documentation and editor icon for tween_resource.gd * Added documentation for camera_3D_resource.gd * Fixed issue when assigning empty target(s) on editor start * Updated editor icons and removed unused * Viewfinder 2d (#220) * Initial working 2D viewfinder * Updated gizmo icon - [Removed] Old Gizmo icon(s) - [Updated] viewfinder_panel.tscn with improved icon sizing layout * Improved 2D viewfinder - [Renamed] Lowercased ...2D and ...3D to 2d/3d in various variable names * Improved aspect ratio scaler * Improved viewfinder logic checker * Removed commented out logic * CleanED up viewfinder file - [Removed] editor_interface variables and replaced with singleton Class ref - [Removed] Unneeded conditional checker and logic * Simplified scene change signal function * Solved error with viewfinder Now no longer being referenced from export builds * Updated example scenes * Added missing PCamHost to 2DExampleScene.tscn * Initial 3D noise support - [Added] phantom_camera_noise_3d.gd - [Added] placeholder phantom_camera_noise_2d.gd - [Added] 3DNoiseExampleScene.tscn - [Added] player_controller_first_person.gd - [Updated] phantom_camera_3D.gd with noise setup - [Updated] phantom_camera_host.gd with noise setup * Fixed issue where various setters for _follow_spring_arm didn't get applied at runtime * Added 2d rotation tween support * Fixed issue with stacking viewfinder Occured if you changed from one PCam to another that both used Framed Follow * Cherry picked changes from main branch * Added instance validator on _exit_tree() * First pass for 3D _validate_property() * Added additional 3D properties * Fixed jitter for none physics object (#179) * Update README.md * Added a checker for PCam Host when a PCam exits the scene (#175) * Fixed jitter for none physics object --------- Co-authored-by: Marcus Skov <Hello@MarcusSkov.com> * Updated viewfinder.gd * Minor property reference updates * Updated phantom_camera_3D.gd and phantom_camera_2D.gd * Updated plugin.cfg to 0.7 * Updated more properties and example scenes * Minor updates * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * 171 third person quaternion (#190) * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * Added quaternion setter/getter for Third Person Follow * Embedded enums to PCam3D script directly * Added additional doc comments * Updated 3D example scenes * Merged #191 into 0.7 * (Re)added draw limits variable to PCam2D * Updated script documentation * Added more properties and signals to PCam scripts - [Removed] Remaining constant. variable uses - [Added] dead_zone_changed signal - [Added] PhantomCameraHost variable to PCam scripts directly - [Updated] viewfinder.gd with the dead_zone_changed signal change - [Updated] pcam active setter in PCamHost using setter method * Added enums directly to tween_resource.gd - [Added] GDScript descriptions to tween resource properties * Changed assign_pcam_host to set_pcam_host * Readded Host to Third Person Example scene * Updated example scenes * Fixed issue with Limit Margin not updating correctly * Updated Tween Resource enum names to align with Tween class * Removed phantom_camera_properties.gd * Swapped yaw and pitch variable names * Removed group_names.gd - [Moved] group_names.gd constants to phantom_camera_constants.gd * Updated example scenes * Added Cull Mask Helper Function - [Added] Setter / Getter for SpringArm3D shape and margin - [Renamed] Camera3DResource setter/getter names * Changed reset_limit_all_sides() to reset_limit() * Removed _camera_3D_resouce_default and tween_resource_default - [Renamed] spring_arm setters/getters - [Added] set_collision_mask_value helper function - [Added] Missing setters/getters * Fixed UI in 2D example scene * Removed tween_resource_default from PCam2D * Updated example scenes * Fixed issue with limit not working after a tween * Updated PCam Host setter/getter * Privitised has_tweened and has_multiple_follow_targets * Renamed pixel_perfect to snap_to_pixel * Added look_at_target_changed signal * Updated many script documentation comments * Added missing default values to phantom_camera scripts * Added comments and privatised variables and functions in phantom_camera_host.gd * Added documentation and editor icon for tween_resource.gd * Added documentation for camera_3D_resource.gd * Fixed issue when assigning empty target(s) on editor start * Updated editor icons and removed unused * Viewfinder 2d (#220) * Initial working 2D viewfinder * Updated gizmo icon - [Removed] Old Gizmo icon(s) - [Updated] viewfinder_panel.tscn with improved icon sizing layout * Improved 2D viewfinder - [Renamed] Lowercased ...2D and ...3D to 2d/3d in various variable names * Improved aspect ratio scaler * Improved viewfinder logic checker * Removed commented out logic * CleanED up viewfinder file - [Removed] editor_interface variables and replaced with singleton Class ref - [Removed] Unneeded conditional checker and logic * Simplified scene change signal function * Solved error with viewfinder Now no longer being referenced from export builds * Updated example scenes * Added missing PCamHost to 2DExampleScene.tscn * Fixed issue where various setters for _follow_spring_arm didn't get applied at runtime * Added 2d rotation tween support * Fixed issue with stacking viewfinder Occured if you changed from one PCam to another that both used Framed Follow * Cherry picked changes from main branch * PhantomCameraManager and NoiseEmitter nodes - [Added] PhantomCameraManager - [Added] PhantomCameraNoiseEmitter2D - [Added] PhantomCameraNoiseEmitter3D - [Updated] Noise example scene and script * Initial 3D noise support - [Added] phantom_camera_noise_3d.gd - [Added] placeholder phantom_camera_noise_2d.gd - [Added] 3DNoiseExampleScene.tscn - [Added] player_controller_first_person.gd - [Updated] phantom_camera_3D.gd with noise setup - [Updated] phantom_camera_host.gd with noise setup * PhantomCameraManager and NoiseEmitter nodes - [Added] PhantomCameraManager - [Added] PhantomCameraNoiseEmitter2D - [Added] PhantomCameraNoiseEmitter3D - [Updated] Noise example scene and script * Changed space indentation to use tabs * Move all spring arm initializaiton code out of _process into _ready (#282) * Move all spring arm initializaiton code out of _process into _ready. Resolves #193 * Making _follow_spring_arm explicitly top_level * Default _follow_spring_arm.position initialization to the original pcam position if follow_target is not available * Updated plugin.cfg to 0.7.1 * Change Camera3DResource.cull_mask to use export_flags_3d_render. Resolves #290 (#293) * Updated scripts and scenes based on changes from Main * Only show viewfinder if the active PCam's mode is framed (#295) * Only show viewfinder in the correct follow mode * Adjust comments * Reorder early returns * Remove unneeded type cast * Updated Editor Updater wording for major releases * Improved Limit Target error setter * Added FUNDING.yml * 2D Follow Physics Interpolation (#294) * Initial _process / _physics_process logic split * More 2d physics interpolation supported - [Added] Interpolation Update Mode to PCamHost - [Added] Additional warnings * Commented out 4.3 specific code * Stripped out a few todo comments * Removed uneeded checkers * Added physics body checker for Group Follow * Added reset_physics_interpolation - [Updated] Physics Interpolation to use string setters * Added physics target checker to PCam3D - [Moved] Follow Targets setters/getters closer to other Follow setters/getters * Aligned PCam2D' script with PCam3D's * Added missing variable assignment * Added missing return for Framed Follow checker * Removed unneeded boolean flag * Tidied up process logic * Added Jitter Tip output * Added physics checker to Look At Group * Updated parameter type from NodePath to Node3D * Updated spacing for setters/getter functions * Set _player_visual to top level in 2D example scene * Added additional jitter context * Phantom Camera Manager (#306) * Initial _process / _physics_process logic split * More 2d physics interpolation supported - [Added] Interpolation Update Mode to PCamHost - [Added] Additional warnings * Commented out 4.3 specific code * Stripped out a few todo comments * Removed uneeded checkers * Added physics body checker for Group Follow * Added reset_physics_interpolation - [Updated] Physics Interpolation to use string setters * Added physics target checker to PCam3D - [Moved] Follow Targets setters/getters closer to other Follow setters/getters * Aligned PCam2D' script with PCam3D's * Added missing variable assignment * Added missing return for Framed Follow checker * Removed unneeded boolean flag * Tidied up process logic * Added Phantom Camera Manager singleton * Minor fix for when not having a PCam in scene * Removed print statement * Fixed merge error * Removed unneeded print statement * Improved viewfinder detection (#307) * Added PCamHost warning when not child of Camera * Additional camera3d parameters (#308) * Added additional PhantomCamera3DResource properties * Shortened Camera3DResource local variable names * Updated Editor Updater to be less intrusive (#309) * Conditional checker for Cam3DRes changes * Added support for disable_3d export templates (#311) * Merged 0.7.2 changes * Renamed 3DNoiseExampleScene.tscn to 3d_noise_example_scene.tscn * Added initial noise properties to PCam 2D * Noise system refactor * Added support for stacked noise output * Removed unneeded transform setter * Prevent a PCam3D's transform from being contaminated from noise * Further noise refinements * Added 2D Noise * Minor cleanup of Noise 3D * Synced active PCam with PCamHost's process * Updated missing transform_output reference * Aligned noise 2D transform output to match the 3D version's * Updated noise 2d example scene * Made Third Person Follow compatible with the transform_output * Updated transform output in phantom_camera_2d.gd --------- Co-authored-by: Timur Turatbekov <44378225+P5ina@users.noreply.github.com> Co-authored-by: ZenithStar <zenithstar@users.noreply.github.com> Co-authored-by: audeck <55060124+audeck@users.noreply.github.com>
ramokz
added a commit
that referenced
this pull request
Oct 18, 2024
* Camera noise (#380) * Added instance validator on _exit_tree() * First pass for 3D _validate_property() * Added additional 3D properties * Fixed jitter for none physics object (#179) * Update README.md * Added a checker for PCam Host when a PCam exits the scene (#175) * Fixed jitter for none physics object --------- Co-authored-by: Marcus Skov <Hello@MarcusSkov.com> * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * Updated viewfinder.gd * Minor property reference updates * Updated phantom_camera_3D.gd and phantom_camera_2D.gd * Updated plugin.cfg to 0.7 * Updated more properties and example scenes * Fixed issue with grabbing active_pcam in viewfinder.gd * Minor updates * 171 third person quaternion (#190) * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * Added quaternion setter/getter for Third Person Follow * Embedded enums to PCam3D script directly * Added additional doc comments * Updated 3D example scenes * Merged #191 into 0.7 * (Re)added draw limits variable to PCam2D * Updated script documentation * Added more properties and signals to PCam scripts - [Removed] Remaining constant. variable uses - [Added] dead_zone_changed signal - [Added] PhantomCameraHost variable to PCam scripts directly - [Updated] viewfinder.gd with the dead_zone_changed signal change - [Updated] pcam active setter in PCamHost using setter method * Added enums directly to tween_resource.gd - [Added] GDScript descriptions to tween resource properties * Changed assign_pcam_host to set_pcam_host * Updated .import files * Readded Host to Third Person Example scene * Updated example scenes * Fixed issue with Limit Margin not updating correctly * Updated Tween Resource enum names to align with Tween class * Removed phantom_camera_properties.gd * Swapped yaw and pitch variable names * Removed group_names.gd - [Moved] group_names.gd constants to phantom_camera_constants.gd * Updated example scenes * Added Cull Mask Helper Function - [Added] Setter / Getter for SpringArm3D shape and margin - [Renamed] Camera3DResource setter/getter names * Changed reset_limit_all_sides() to reset_limit() * Removed _camera_3D_resouce_default and tween_resource_default - [Renamed] spring_arm setters/getters - [Added] set_collision_mask_value helper function - [Added] Missing setters/getters * Fixed UI in 2D example scene * Removed tween_resource_default from PCam2D * Updated example scenes * Fixed issue with limit not working after a tween * Updated PCam Host setter/getter * Privitised has_tweened and has_multiple_follow_targets * Renamed pixel_perfect to snap_to_pixel * Added look_at_target_changed signal * Updated many script documentation comments * Added missing default values to phantom_camera scripts * Added comments and privatised variables and functions in phantom_camera_host.gd * Added documentation and editor icon for tween_resource.gd * Added documentation for camera_3D_resource.gd * Fixed issue when assigning empty target(s) on editor start * Updated editor icons and removed unused * Viewfinder 2d (#220) * Initial working 2D viewfinder * Updated gizmo icon - [Removed] Old Gizmo icon(s) - [Updated] viewfinder_panel.tscn with improved icon sizing layout * Improved 2D viewfinder - [Renamed] Lowercased ...2D and ...3D to 2d/3d in various variable names * Improved aspect ratio scaler * Improved viewfinder logic checker * Removed commented out logic * CleanED up viewfinder file - [Removed] editor_interface variables and replaced with singleton Class ref - [Removed] Unneeded conditional checker and logic * Simplified scene change signal function * Solved error with viewfinder Now no longer being referenced from export builds * Updated example scenes * Added missing PCamHost to 2DExampleScene.tscn * Initial 3D noise support - [Added] phantom_camera_noise_3d.gd - [Added] placeholder phantom_camera_noise_2d.gd - [Added] 3DNoiseExampleScene.tscn - [Added] player_controller_first_person.gd - [Updated] phantom_camera_3D.gd with noise setup - [Updated] phantom_camera_host.gd with noise setup * Fixed issue where various setters for _follow_spring_arm didn't get applied at runtime * Added 2d rotation tween support * Fixed issue with stacking viewfinder Occured if you changed from one PCam to another that both used Framed Follow * Cherry picked changes from main branch * Added instance validator on _exit_tree() * First pass for 3D _validate_property() * Added additional 3D properties * Fixed jitter for none physics object (#179) * Update README.md * Added a checker for PCam Host when a PCam exits the scene (#175) * Fixed jitter for none physics object --------- Co-authored-by: Marcus Skov <Hello@MarcusSkov.com> * Updated viewfinder.gd * Minor property reference updates * Updated phantom_camera_3D.gd and phantom_camera_2D.gd * Updated plugin.cfg to 0.7 * Updated more properties and example scenes * Minor updates * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * 171 third person quaternion (#190) * Updated CharacterControllers to support changed camera movement interpolation. * Removed unneeded interpolation from phantom_camera_3D.gd * Added quaternion setter/getter for Third Person Follow * Embedded enums to PCam3D script directly * Added additional doc comments * Updated 3D example scenes * Merged #191 into 0.7 * (Re)added draw limits variable to PCam2D * Updated script documentation * Added more properties and signals to PCam scripts - [Removed] Remaining constant. variable uses - [Added] dead_zone_changed signal - [Added] PhantomCameraHost variable to PCam scripts directly - [Updated] viewfinder.gd with the dead_zone_changed signal change - [Updated] pcam active setter in PCamHost using setter method * Added enums directly to tween_resource.gd - [Added] GDScript descriptions to tween resource properties * Changed assign_pcam_host to set_pcam_host * Readded Host to Third Person Example scene * Updated example scenes * Fixed issue with Limit Margin not updating correctly * Updated Tween Resource enum names to align with Tween class * Removed phantom_camera_properties.gd * Swapped yaw and pitch variable names * Removed group_names.gd - [Moved] group_names.gd constants to phantom_camera_constants.gd * Updated example scenes * Added Cull Mask Helper Function - [Added] Setter / Getter for SpringArm3D shape and margin - [Renamed] Camera3DResource setter/getter names * Changed reset_limit_all_sides() to reset_limit() * Removed _camera_3D_resouce_default and tween_resource_default - [Renamed] spring_arm setters/getters - [Added] set_collision_mask_value helper function - [Added] Missing setters/getters * Fixed UI in 2D example scene * Removed tween_resource_default from PCam2D * Updated example scenes * Fixed issue with limit not working after a tween * Updated PCam Host setter/getter * Privitised has_tweened and has_multiple_follow_targets * Renamed pixel_perfect to snap_to_pixel * Added look_at_target_changed signal * Updated many script documentation comments * Added missing default values to phantom_camera scripts * Added comments and privatised variables and functions in phantom_camera_host.gd * Added documentation and editor icon for tween_resource.gd * Added documentation for camera_3D_resource.gd * Fixed issue when assigning empty target(s) on editor start * Updated editor icons and removed unused * Viewfinder 2d (#220) * Initial working 2D viewfinder * Updated gizmo icon - [Removed] Old Gizmo icon(s) - [Updated] viewfinder_panel.tscn with improved icon sizing layout * Improved 2D viewfinder - [Renamed] Lowercased ...2D and ...3D to 2d/3d in various variable names * Improved aspect ratio scaler * Improved viewfinder logic checker * Removed commented out logic * CleanED up viewfinder file - [Removed] editor_interface variables and replaced with singleton Class ref - [Removed] Unneeded conditional checker and logic * Simplified scene change signal function * Solved error with viewfinder Now no longer being referenced from export builds * Updated example scenes * Added missing PCamHost to 2DExampleScene.tscn * Fixed issue where various setters for _follow_spring_arm didn't get applied at runtime * Added 2d rotation tween support * Fixed issue with stacking viewfinder Occured if you changed from one PCam to another that both used Framed Follow * Cherry picked changes from main branch * PhantomCameraManager and NoiseEmitter nodes - [Added] PhantomCameraManager - [Added] PhantomCameraNoiseEmitter2D - [Added] PhantomCameraNoiseEmitter3D - [Updated] Noise example scene and script * Initial 3D noise support - [Added] phantom_camera_noise_3d.gd - [Added] placeholder phantom_camera_noise_2d.gd - [Added] 3DNoiseExampleScene.tscn - [Added] player_controller_first_person.gd - [Updated] phantom_camera_3D.gd with noise setup - [Updated] phantom_camera_host.gd with noise setup * PhantomCameraManager and NoiseEmitter nodes - [Added] PhantomCameraManager - [Added] PhantomCameraNoiseEmitter2D - [Added] PhantomCameraNoiseEmitter3D - [Updated] Noise example scene and script * Changed space indentation to use tabs * Move all spring arm initializaiton code out of _process into _ready (#282) * Move all spring arm initializaiton code out of _process into _ready. Resolves #193 * Making _follow_spring_arm explicitly top_level * Default _follow_spring_arm.position initialization to the original pcam position if follow_target is not available * Updated plugin.cfg to 0.7.1 * Change Camera3DResource.cull_mask to use export_flags_3d_render. Resolves #290 (#293) * Updated scripts and scenes based on changes from Main * Only show viewfinder if the active PCam's mode is framed (#295) * Only show viewfinder in the correct follow mode * Adjust comments * Reorder early returns * Remove unneeded type cast * Updated Editor Updater wording for major releases * Improved Limit Target error setter * Added FUNDING.yml * 2D Follow Physics Interpolation (#294) * Initial _process / _physics_process logic split * More 2d physics interpolation supported - [Added] Interpolation Update Mode to PCamHost - [Added] Additional warnings * Commented out 4.3 specific code * Stripped out a few todo comments * Removed uneeded checkers * Added physics body checker for Group Follow * Added reset_physics_interpolation - [Updated] Physics Interpolation to use string setters * Added physics target checker to PCam3D - [Moved] Follow Targets setters/getters closer to other Follow setters/getters * Aligned PCam2D' script with PCam3D's * Added missing variable assignment * Added missing return for Framed Follow checker * Removed unneeded boolean flag * Tidied up process logic * Added Jitter Tip output * Added physics checker to Look At Group * Updated parameter type from NodePath to Node3D * Updated spacing for setters/getter functions * Set _player_visual to top level in 2D example scene * Added additional jitter context * Phantom Camera Manager (#306) * Initial _process / _physics_process logic split * More 2d physics interpolation supported - [Added] Interpolation Update Mode to PCamHost - [Added] Additional warnings * Commented out 4.3 specific code * Stripped out a few todo comments * Removed uneeded checkers * Added physics body checker for Group Follow * Added reset_physics_interpolation - [Updated] Physics Interpolation to use string setters * Added physics target checker to PCam3D - [Moved] Follow Targets setters/getters closer to other Follow setters/getters * Aligned PCam2D' script with PCam3D's * Added missing variable assignment * Added missing return for Framed Follow checker * Removed unneeded boolean flag * Tidied up process logic * Added Phantom Camera Manager singleton * Minor fix for when not having a PCam in scene * Removed print statement * Fixed merge error * Removed unneeded print statement * Improved viewfinder detection (#307) * Added PCamHost warning when not child of Camera * Additional camera3d parameters (#308) * Added additional PhantomCamera3DResource properties * Shortened Camera3DResource local variable names * Updated Editor Updater to be less intrusive (#309) * Conditional checker for Cam3DRes changes * Added support for disable_3d export templates (#311) * Merged 0.7.2 changes * Renamed 3DNoiseExampleScene.tscn to 3d_noise_example_scene.tscn * Added initial noise properties to PCam 2D * Noise system refactor * Added support for stacked noise output * Removed unneeded transform setter * Prevent a PCam3D's transform from being contaminated from noise * Further noise refinements * Added 2D Noise * Minor cleanup of Noise 3D * Synced active PCam with PCamHost's process * Updated missing transform_output reference * Aligned noise 2D transform output to match the 3D version's * Updated noise 2d example scene * Made Third Person Follow compatible with the transform_output * Updated transform output in phantom_camera_2d.gd --------- Co-authored-by: Timur Turatbekov <44378225+P5ina@users.noreply.github.com> Co-authored-by: ZenithStar <zenithstar@users.noreply.github.com> Co-authored-by: audeck <55060124+audeck@users.noreply.github.com> * Prevent crash when freeing target parent (#381) * Improved follow target being cleared * Improved 2D follow target being cleared * Changed variable name to _follow_target_is_tree_exiting * Improved look at target being cleared * Improved clearing targets for Group Follow and Group Look At * Minor addition to previous commit * Added dead_zone_reached signal (#382) * Resolved viewfinder error spam log (#386) * Updated copy in _check_physics_body * Refactored how targets are store and referenced in phantom_camera_3d.gd * Fixed an issue with look at damping not working * Refactored how targets are stored and referenced in phantom_camera_2d.gd * Updated plugin.cfg to 0.7.9 * Updated Path Follow reference with refactored system * Added _should_follow_checker to validate follow target * Resolved 2D Framed View change from pre-0.8 branch * Updated dev scenes * Updated dev scene scripts * Added Phantom Camera Noise icons * Made the Noise system more flexible * Updated Noise behaviour * Set Noise Rotation Z default to 0 * Updated 3D Noise Example Scene * Updated 2D Noise Example Scene * Updated 2D Example Scenes * Updated 3D Example Scenes * Prevent updater from updating to pre-releases * Minor update to 2d_limit_example_scene.tscn * Minor update to viewfinder_panel.tscn * Updated player_sprite.svg to a 128x128 size * Minor check fix * Assigned TileMapLayer as initial limit target * Minor noise example scene changes * Added private _follow_targets variable * Minor 3d noise examples * Prevented _follow_targets_size_check from being checked when not Group Follow * Only show Auto Follow Distance properties when appropriate * Only show Auto Zoom properties when appropriate * Reverted spring_arm add_child method to use parent node instead of scene root * Resolved "data.tree" is null error due to camera_2d physics interpolation being set to off * Resolved process_callback change warning Happens if physics interpolation is enabled from Project Settings * Minor changes * Fixed issue when setting Follow Mode without a target * Updated player_character_body_2d_4.3.gd to use TileMapLayer * Updated dev_scene_2d.tscn * Ignore_rotation checker for Noise2D * Added setters and getters for Noise Resources * Added setters & getters to Noise Emitters * Minor dev_scene_3d.tscn change * Updated noise example scenes * Added additional GDScript documentation to Noise files * Assigned default value to noise property --------- Co-authored-by: Timur Turatbekov <44378225+P5ina@users.noreply.github.com> Co-authored-by: ZenithStar <zenithstar@users.noreply.github.com> Co-authored-by: audeck <55060124+audeck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #290