Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate banks file by countries #12

Closed
altmind opened this issue Jan 15, 2016 · 3 comments
Closed

Separate banks file by countries #12

altmind opened this issue Jan 15, 2016 · 3 comments

Comments

@altmind
Copy link
Contributor

altmind commented Jan 15, 2016

There are many banks that work internationally, we need to have one bank-json for bank operating in each country.

For example, there are Sberbank in CZ in BY and in RU. There is VTB in RU and BY. There are Alfabank in RU and BY.

I suggest that we create directory for each country in banks folder and put ambigous jsons here.
Non-ambigous jsons may be left where they are. We also need to adjust build scripts?

What do you think? Will PR with those changes be welcome?

@ai
Copy link
Contributor

ai commented Jan 15, 2016

Looks good. At least every bank can work only in one country, as I know.

@ai
Copy link
Contributor

ai commented Jan 15, 2016

Also mayb you should wait @ramoona decision. I am here only as Éminence grise.

@ramoona ramoona mentioned this issue Feb 9, 2016
@ramoona
Copy link
Owner

ramoona commented Feb 29, 2016

done in 0.7.0 release :)

@ramoona ramoona closed this as completed Feb 29, 2016
ramoona pushed a commit that referenced this issue Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants