Add new manipulation and analyze methods for collections. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add the following methods: columns, first, last, sort, filter, where, map, diff, intersect, unique, merge
Added a phpstan.neon to be able to validate prophecy calls.
jmauerhan
reviewed
Oct 5, 2018
jmauerhan
reviewed
Oct 5, 2018
jmauerhan
suggested changes
Oct 5, 2018
|
Will update after I got my little girl to sleep ;) |
|
Would using array_values instead of merging it with an empty array work?
The array_merge with the extra array is a little confusing to read, and I
wonder about performance?
…On Fri, Oct 5, 2018, 11:48 AM Andreas Frömer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/AbstractCollection.php
<#44 (comment)>:
> + $temp[] = $this->extractValue($item, $propertyOrMethod);
+ }
+
+ return $temp;
+ }
+
+ /**
+ * @inheritdoc
+ */
+ public function first()
+ {
+ if (empty($this->data)) {
+ throw new OutOfBoundsException('Can\'t determine first item. Collection is empty');
+ }
+
+ $temp = array_merge([], $this->data);
Because of the nature of array_shift and array_pop which will alter the
target array. This will make sure I will lose the reference of the current
data array.
And because the key of the data list is not necessary numeric I just use
internal function to get the last or first item.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#44 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEAm5lH_ohfG1XCVjKMBskEXkTLODjxaks5uh39ngaJpZM4XC_Mg>
.
|
|
Yep. I just changed it to use the internal array pointer with |
This will now used the internal array pointer instead of copying the whole collection. This should improve the performance
Remove unique() method for now, as the definition of "uniqueness" is still under discussion
This should cover all possible outcomes of the ValueExtractorTrait
This will separate the tests for manipulating a collection from the default operations. This should make sure everyone knows what these tests are doing and why they are doing what they do ;)
shadowhand
reviewed
Oct 5, 2018
This will call some internal functions from root namespace to benefit from opcode optimization
This was referenced Oct 5, 2018
|
@jmauerhan as you requested changes, can you give it another look? |
jmauerhan
reviewed
Oct 24, 2018
|
@jmauerhan renamed the exception. |
|
Awesome. Thank you 😊 |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #13.
This will add the following methods:
The methods have been implemented according to the suggested API. If you want any change to these methods. Keep me posted.