Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.7.patch1] Resolve issues with user last login fields #11091

Merged
merged 5 commits into from
May 22, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This is an automated request to port PR #11078 by @rak-phillip

Original PR body:

Summary

This addresses several issues identified with new Login fields added to the users table

  • When Disable/Delete After fields reach 0, the relative date would start counting up
  • When a user is disabled, there is no need to display a value for Disable After
  • Update the user states to reach Enabled/Disabled instead of Active/Inactive
  • Add a suffix to the last login column

Fixes #11074
Fixes #11071

Technical notes summary

I originally attempted to expose the live date components through the cell slots for the table, but I found that the LiveDate component no longer works with this change. It appears that LiveDate is receiving updates via the prop on a regular basis while rendering from within the table, but that relationship is broken when data is exposed through a slot. I opted to add a new prop to the LiveDate component, but we can also consider creating a new component to handle a countdown like this if we would prefer.

Areas or cases that should be tested

  • Users List
  • User Details

Set a short time (2 minutes) for disable/delete after. Watch the timer countdown.

Alternatively, disable a user before the countdown reaches zero.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants