Add support for python3 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nhumrich I feel a bit stupid in that I never noticed this PR. I'm interested in merging this. What I can do is pull this PR into our validation tests for Rancher which extensively use the client as a way to validate that it doesn't break existing Python 2. We don't really use Python 3 so I can only vouch for Python 2. |
|
thats fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: rancher/rancher#2106
I make no promises that it is completely compatible, but I can at least import, create a client, and make some api calls on python2 and 3.
Since there are not tests to run, I have no way to validate I didn’t break some obscure feature.