Fix publish build #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snasovich
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
This should indeed fix the issue.
However it's weird that when running apt-get install before modifications on 20.04 we do get iptables while we don't on 21.10. Probably some of dozen+ packages we pull install it on 20.04 but not on 21.10.
@kinarashah @Oats87 , just copying you to ensure it's OK. Please take a peek. Will merge once I hear back from one of them.
Oats87
approved these changes
Jan 10, 2022
kinarashah
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the publish build CI. Earlier it was not able to find the
iptablesbinary inside/usr/sbinor/sbinthat's whyiptables-wrapper-installer.shwas throwing the error https://drone-publish.rancher.io/rancher/hyperkube-base/16/1/3.For: rancher/rancher#35709, continuation of #7