Skip to content

Conversation

vardhaman22
Copy link

@vardhaman22 vardhaman22 commented Dec 1, 2022

@vardhaman22 vardhaman22 changed the base branch from master to v1.25 December 1, 2022 13:01
@vardhaman22 vardhaman22 changed the title k8s version update for 2022 December patch release k8s version update for 2022 December patch release: 1.25.5 Dec 1, 2022
@macedogm
Copy link
Member

macedogm commented Dec 6, 2022

@vardhaman22 can we also update your PR to use rancher/hyperkube-base:v0.0.15 instead of rancher/hyperkube-base:v0.0.14, please?

The 0.15 is a bit more recent and has important updates in base OS packages to fix CVEs. The other 2 PRs are already using the right version.

snasovich
snasovich previously approved these changes Dec 6, 2022
Copy link
Collaborator

@snasovich snasovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM (save for addressing @macedogm's comment), waiting for upstream release.
Approving assuming the hyperkube-base image is changed and build passes following upstream release.

Copy link

@sbstp sbstp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @snasovich's previous comment

@sbstp sbstp requested a review from a team December 9, 2022 16:43
@vardhaman22 vardhaman22 merged commit cfd1c29 into rancher:v1.25 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants