[v1.24] use container stats from cadvisor for cri-dockerd #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinarashah
changed the title
|
Note: This PR is still marked as WIP because yet to add drone build logic for it. But following tags have the linked fix for testing purposes: They have been pulled into rancher/hyperkube for |
kinarashah
force-pushed
the
v12410
branch
2 times, most recently
from
c0a45ed
to
2c8a88b
Compare
kinarashah
force-pushed
the
v12410
branch
2 times, most recently
from
4bc359b
to
ff1043a
Compare
snasovich
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The main issue around cpu spike with >=v1.24 RKE1 clusters is Kubernetes deprecating internal dockershim with 1.24 and Rancher now using cri-dockerd - this means that all stats are now collected by cri-dockerd talking to docker api directly instead of getting them from cadvisor. The docker calls themselves seem to be the bottleneck, which changes from system to system. (This is confirmed by internal testing and varying results on different user setups).
rancher/rancher#38816
Fix
The workaround would be to build our own kubelet that installs docker plugin for cadvisor and continue reading stats the old way.