Skip to content

Conversation

kinarashah
Copy link
Member

@kinarashah kinarashah commented Feb 14, 2023

Downloading from https://github.com/rancher/kubernetes/releases/tag/v1.24.10-rc.1-rancher1, final release tag v1.24.10 will be updated later once drone logic for rancher/kubernetes is added.

The rc tag has this fix rancher/kubernetes#74

Issue: rancher/rancher#38816

@kinarashah kinarashah requested a review from a team February 14, 2023 05:29
@kinarashah kinarashah changed the base branch from v1.24 to v1.24-custom February 14, 2023 19:03
@jakefhyde jakefhyde requested a review from a team February 14, 2023 19:24
Copy link

@Oats87 Oats87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; pending we remove that temporary suffix on the k8s version from the download...

cd k8s-tars/${K8S_VERSION}/${ARCH} && curl -sSLO --retry 5 https://dl.k8s.io/${K8S_VERSION}/${K8S_SERVER_TARBALL}

cd k8s-tars/${K8S_VERSION}/${ARCH} && curl -sSLO --retry 5 https://dl.k8s.io/${K8S_VERSION}/${K8S_SERVER_TARBALL} \
&& curl -sSLO --retry 5 https://github.com/rancher/kubernetes/releases/download/${K8S_VERSION}-rc.1-rancher1/kubelet-${K8S_VERSION}-${ARCH}.tar.gz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is temporary right...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, final release tag will be only ${K8S_VERSION}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants