Skip to content

Fixing external authed users migration #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Fixing external authed users migration #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/cluster/projectroletemplatebinding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,20 @@ func (p *ProjectRoleTemplateBinding) Mutate(clusterName, projectName string) {
}

func (p *ProjectRoleTemplateBinding) SetDescription(ctx context.Context, client *client.Clients) error {
if p.Obj.UserName == "" && p.Obj.UserPrincipalName == "" {
groupName := p.Obj.GroupName
if groupName == "" {
// handling external auth providers
groupName = p.Obj.GroupPrincipalName
}
p.Description = fmt.Sprintf("%s permission for group %s", p.Obj.RoleTemplateName, groupName)
return nil
}
// setting description for external users
if p.Obj.UserPrincipalName != "" {
p.Description = fmt.Sprintf("%s permission for user %s", p.Obj.RoleTemplateName, p.Obj.UserPrincipalName)
return nil
}
var user v3.User
userID := p.Obj.UserName
if err := client.Users.Get(ctx, "", userID, &user, v1.GetOptions{}); err != nil {
Expand Down