Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

Update the z-index value of the settings menu #670

Merged
merged 2 commits into from
Sep 16, 2016

Conversation

hilaryhacksel
Copy link
Contributor

@hilaryhacksel hilaryhacksel commented Sep 15, 2016

Resolves #661

@mention-bot
Copy link

@hilaryhacksel, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vanessayuenn, @xorgy and @clbond to be potential reviewers

@sumitarora
Copy link
Member

:shipit:

Copy link
Contributor

@xorgy xorgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we should perhaps reorganize and document the various Z indices of things, but this should be good enough for now.

Though this change is probably enough, I think that there should only be one dropdown/context menu on the screen at once, so you can afford to put it much higher (say, 1000) which gives us much more room to stack other things.

@hilaryhacksel hilaryhacksel added this to the 1.1.4 milestone Sep 15, 2016
@igor-ka
Copy link

igor-ka commented Sep 15, 2016

@xorgy do you want changes made to this PR? If not, @hilaryhacksel let's merge it and move on for now.

@xorgy
Copy link
Contributor

xorgy commented Sep 15, 2016

I would prefer the z-index be set more than 1 greater than the thing it was conflicting with, so that we can put something in between them in the future.

@xorgy xorgy removed this from the 1.1.4 milestone Sep 16, 2016
@hilaryhacksel hilaryhacksel merged commit 76d3f74 into rangle:dev Sep 16, 2016
@hilaryhacksel hilaryhacksel deleted the zindex-menu-fix branch September 16, 2016 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants