Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

Make sure emitter values are emitted within the ngZone #751

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Make sure emitter values are emitted within the ngZone #751

merged 1 commit into from
Oct 25, 2016

Conversation

stevenkampen
Copy link
Contributor

@stevenkampen stevenkampen commented Oct 25, 2016

This resolves an issue where changes to an inspected app that are a result of events emitted from Augury (as opposed to the same events emitted naturally through the app), do not result in the component tree being updated.

resolves #752

@vanessayuenn FYI.

@mention-bot
Copy link

@stevenkampen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @clbond, @sumitarora and @winkerVSbecks to be potential reviewers.

Copy link

@igor-ka igor-ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenkampen the code makes perfect sense.

Please create a github issues describing the problem we are addressing, and link it to this PR for everyone's reference. I will give it the approval after.

@igor-ka igor-ka self-assigned this Oct 25, 2016
@stevenkampen
Copy link
Contributor Author

resolves #752

@stevenkampen
Copy link
Contributor Author

@igor-ka Please approve. Release incoming.

Copy link

@igor-ka igor-ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@stevenkampen stevenkampen merged commit 182e031 into rangle:dev Oct 25, 2016
@stevenkampen stevenkampen deleted the emit-value-run-in-ng-zone branch October 25, 2016 14:45
@stevenkampen
Copy link
Contributor Author

Will do.

On Oct 25, 2016, 4:06 PM +0200, Igor Kamenetsky notifications@github.com, wrote:

@igor-ka commented on this pull request.

@stevenkampen (https://github.com/stevenkampen) the code makes perfect sense.

Please create a github issues describing the problem we are addressing, and link it to this PR for everyone's reference. I will give it the approval after.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#751 (review)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AA22yxCYmX6Ng9FiJ53u2QyI8xE9ZNPlks5q3gz6gaJpZM4KfuTw).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants