Skip to content

Conversation

poadoc
Copy link

@poadoc poadoc commented Oct 8, 2020

@mrin9
Copy link
Collaborator

mrin9 commented Oct 10, 2020

Thanks for the PR. It is a great contribution.

We are in the process of receiving feedback from our design team and user-base for the features. Also testing performance with large specs.

Following are some of the findings

  • Design team wanted some minor style changes. Also there should be support for both dark and light theme. currently it supports only the light theme
  • User base and User-experience have reported some tweaks to the way the search result is represented
  • It should offer more flexibility in terms of what user like to search... not just parameter search
  • do not search parameter descriptions/summary as some large specs gets into performance issues

But having said that, DO NOT UPDATE this PR. We are still reviewing this
We are more likely to accept this PR as is to record your contribution and then make some tweaks to it once we complete the feedback process

@mrin9 mrin9 merged commit b4f69f7 into rapi-doc:master Oct 12, 2020
@mrin9
Copy link
Collaborator

mrin9 commented Oct 12, 2020

Thanks for the great PR !!!

@poadoc poadoc deleted the search-by-parameters branch October 13, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants