- Fixed navbar active path/tag/link #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed loading state when spec changes Signed-off-by: Dharmendra <dharmendra.patel26@gmail.com>
mrin9
requested changes
Dec 8, 2020
src/rapidoc.js
Outdated
| } | ||
| } | ||
|
|
||
| resetDoc() { |
There was a problem hiding this comment.
resetDoc name is misleading, there are many states in a the doc, it is just reseting the loader and some classes.
IMO, we do not need a separate method for this, just put these statements in loadSpec() method
src/rapidoc.js
Outdated
| this.loadFailed = false; | ||
| this.requestUpdate(); | ||
|
|
||
| // Remove the previous active tag |
There was a problem hiding this comment.
NavBar is available in read and focused mode only, so check if renderStyle is focused or read then only perform these statements
There was a problem hiding this comment.
Updated PR
Dharmendra205111014
force-pushed
the
bugfix/reset-state-on-spec-change
branch
from
b6fa1ef to
416f673
Compare
mrin9
approved these changes
Dec 9, 2020
|
Thanks for the PR !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Few more fixes in continuation of issue #377 and last PR #378
Signed-off-by: Dharmendra dharmendra.patel26@gmail.com