-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOAR-6425 Trendmicro Deepsecurity Fix Memory Leak- Request Session #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmara-r7
added
Work in Progress 🚧
PR is in progress
Do Not Merge ⛔
PR should not be merged
labels
Sep 21, 2021
plugins/trendmicro_deepsecurity/icon_trendmicro_deepsecurity/actions/get_rule_details/action.py
Outdated
Show resolved
Hide resolved
pmara-r7
removed
Work in Progress 🚧
PR is in progress
Do Not Merge ⛔
PR should not be merged
labels
Sep 23, 2021
mrinehart-r7
requested changes
Sep 23, 2021
plugins/trendmicro_deepsecurity/icon_trendmicro_deepsecurity/actions/search_rules/action.py
Outdated
Show resolved
Hide resolved
plugins/trendmicro_deepsecurity/icon_trendmicro_deepsecurity/actions/search_rules/action.py
Outdated
Show resolved
Hide resolved
mberezin-r7
previously approved these changes
Sep 24, 2021
pmara-r7
commented
Sep 24, 2021
mberezin-r7
approved these changes
Sep 24, 2021
mberezin-r7
reviewed
Sep 27, 2021
default: "" | ||
example: "42" | ||
default: 0 | ||
example: 42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct answer
mberezin-r7
approved these changes
Sep 27, 2021
mrinehart-r7
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove the requests library 'session' as it can cause memory leaks, per
psf/requests#4601
Could use the .close() method on the session, but that removes the only valuable functionality that request sessions provide, so changed to using normal get and post requests.
Description
Describe the proposed changes:
PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblekomand/python-3-37-slim-plugin
andkomand/python-3-37-plugin
make validate
which callsmdl
to linthelp.md
Functional Checklist
tests/
directory created withicon-plugin run -c sample $action > tests/$action.json
tests/$action_bad.json
icon-plugin run -T tests/example.json --debug --jq
icon-plugin run -T all --debug --jq
(use PR format at end)icon-plugin run -R tests/example.json --debug --jq
icon-plugin run -R all --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
make validate
and make sure everything passesicon-plugin run -A -R all -T all
. For single action validation:icon-plugin run -A -R tests/my_action.json -T tests/my_action.json
icon-plugin ... | pbcopy
) and paste the output in a new post on this PR