Allow HttpClient to remember my cookie #2697
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the target host sets a cookie, the Httpclient should remember it. That way in the module I won't have to manually extract it, and then put it in the next request.
If some for reason the module decides to send to different hosts, the HttpClient mixin should know which one to use. Also, as you can see only send_request_cgi() uses this feature, I don't think send_request_raw should be using it because it's supposed to be the most basic form of send_request_*.
For testing, use test/modules/auxiliary/test/cookie_test.rb, and then you'll have to use wireshark to verify it's working properly. You can set the rhost to 208.118.237.137 if you want, that's metasploit.com.
[SeeRM #8706]