-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String support for jcudf row to cudf column conversion #10871
String support for jcudf row to cudf column conversion #10871
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10871 +/- ##
================================================
+ Coverage 86.29% 86.32% +0.02%
================================================
Files 144 144
Lines 22656 22668 +12
================================================
+ Hits 19552 19569 +17
+ Misses 3104 3099 -5
Continue to review full report at Codecov.
|
I don't see any unit test for verifying the correctness of the function(s)? It would be nice to have a round trip test ( |
Co-authored-by: Nghia Truong <ttnghia@users.noreply.github.com>
…df-row-col-strings
I agree, but the java directory isn't included in cudf tests. We have tests on the java side, but the strings aren't tested there yet. I have a test set that I use for testing, but I have to copy the |
…2346/cudf into mwilson/jcudf-row-col-strings
rerun tests |
1 similar comment
rerun tests |
@gpucibot merge |
This PR adds support for string column creation from jcudf row data. It leverages the fixed-width data copy to convert the offsets and lengths stored inside the fixed-width data section and then uses that information to copy the string data itself from the jcudf row format into the cudf column.
closes #10286