Fix unsanitized nulls produced by libcudf dictionary decode #14578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
davidwendt
added
3 - Ready for Review
ttnghia
reviewed
Dec 6, 2023
ttnghia
approved these changes
Dec 6, 2023
3 tasks
mythrocks
reviewed
Dec 7, 2023
| @@ -30,6 +29,18 @@ | |||
| namespace cudf { | |||
| namespace dictionary { | |||
| namespace detail { | |||
| namespace { | |||
| struct indices_handler_fn { | |||
There was a problem hiding this comment.
Thanks for fixing this. Would there be value in naming this functor a "nullifying_handler" or some such?
There was a problem hiding this comment.
The actually nullifying happens far away in the gather function. This function simply returns indices.
|
/merge |
karthikeyann
pushed a commit
to karthikeyann/cudf
that referenced
this pull request
Dec 12, 2023
…#14578) Fixes `cudf::dictionary::decode` logic to produced sanitized null entries for compound column types. Reference: rapidsai#14559 -- fixes many of the errors found here concerning dictionary column gtests. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - MithunR (https://github.com/mythrocks) URL: rapidsai#14578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
cudf::dictionary::decodelogic to produced sanitized null entries for compound column types.Reference: #14559 -- fixes many of the errors found here concerning dictionary column gtests.
Checklist