Update dependencies.yaml to support CUDA 12.*. #14644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
vyasr
approved these changes
Dec 18, 2023
ajschmidt8
approved these changes
Dec 20, 2023
|
I might need to do a bit more refactoring here, but I'm going to merge this for now and re-assess the next steps. Merging the current state will help me with testing CUDA 12.2 even if it's not the final form. |
|
/merge |
3 tasks
3 tasks
ajschmidt8
pushed a commit
that referenced
this pull request
Jan 11, 2024
Follow-up to #14644. Contributes to rapidsai/build-planning#7. Similar to rapidsai/rmm#1422, this proposes splitting the `cuda-version` dependency in `dependencies.yaml` out to its own thing, separate from the bits of the CUDA Toolkit `cudf` needs. Some other simplifications: * removes the notebook-specific stuff added in #14722 (which I think were added specifically because `cuda-version` and CTK stuff was coupled) * consolidates two sections with selectors only based on CUDA `{major}.{minor}` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ray Douglass (https://github.com/raydouglass) - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
dependencies.yamlso that generic CUDA 12.* dependencies can be specified with a glob, likecuda: "12.*". This feature requiresrapids-dependency-file-generator>=1.8.0, so the pre-commit hook has been updated.I have not yet added support for a specific CUDA version like 12.1 or 12.2. That can be done separately.
Checklist