-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use offsetalator in gather_chars #14700
Merged
rapids-bot
merged 6 commits into
rapidsai:branch-24.02
from
davidwendt:gather-chars-offsetalator
Jan 8, 2024
Merged
Use offsetalator in gather_chars #14700
rapids-bot
merged 6 commits into
rapidsai:branch-24.02
from
davidwendt:gather-chars-offsetalator
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Currently a work in progress
libcudf
Affects libcudf (C++/CUDA) code.
strings
strings issues (C++ and Python)
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Jan 3, 2024
davidwendt
added
3 - Ready for Review
Ready for review by team
and removed
2 - In Progress
Currently a work in progress
labels
Jan 5, 2024
ttnghia
approved these changes
Jan 5, 2024
PointKernel
reviewed
Jan 5, 2024
PointKernel
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
strings
strings issues (C++ and Python)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
cudf::strings::detail::gather_chars()
utility to use the offsetalator iterators.The offsetalator enables the utility to use int32 or int64 offsets in the future with no additional changes.
This utility is mainly used by a
make_strings_column
factory and is already optimized for columns with both long and short strings.The
input_offsetalator
is also updated to include an additional optional offset parameter for cases where the parent strings column has been sliced and requires building the iterator starting from a non-zero index within the offsets child column.Checklist