-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce basic "cudf" backend for Dask Expressions #14805
Merged
rapids-bot
merged 136 commits into
rapidsai:branch-24.04
from
rjzamora:new-dask-expr-backend
Mar 11, 2024
Merged
Introduce basic "cudf" backend for Dask Expressions #14805
rapids-bot
merged 136 commits into
rapidsai:branch-24.04
from
rjzamora:new-dask-expr-backend
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
2 - In Progress
Currently a work in progress
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Jan 19, 2024
…o new-dask-expr-backend
rjzamora
added
3 - Ready for Review
Ready for review by team
4 - Needs Review
Waiting for reviewer to review or respond
and removed
2 - In Progress
Currently a work in progress
3 - Ready for Review
Ready for review by team
labels
Mar 5, 2024
raydouglass
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ops-codeowners
changes look good
/merge |
rjzamora
added
5 - Ready to Merge
Testing and reviews complete, ready to merge
and removed
4 - Needs Review
Waiting for reviewer to review or respond
labels
Mar 10, 2024
I'll merge the upstream so that the |
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
Fixes CI blocked by dask-expr. xref: - #14805 - rapidsai/rapids-dask-dependency#33 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #15343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly addresses #15027
dask/dask-expr#728 exposed the necessary mechanisms for us to define a custom dask-expr backend for
cudf
. The new dispatching mechanisms are effectively the same as those indask.dataframe
. The only difference is that we are now registering/implementing "expression-based" collections.This PR does the following:
DataFrameBackendEntrypoint
class for collection creation, and registers new collections usingget_collection_type
.dask_cudf
import structure to properly support the"dataframe.query-planning"
configuration.dask_cudf
tests. This coverage can be expanded in follow-up work.Experimental Change: This PR patchesdask_expr._expr.Expr.__new__
to enable type-based dispatching. This effectively allows us to surgically replace problematicExpr
subclasses that do not work for cudf-backed data. For example, this PR replaces the upstreamTakeLast
expression to avoid usingsqueeze
(since this method is not supported by cudf). This particular fix can be moved upstream relatively easily. However, having this kind of "patching" mechanism may be valuable for more complicated pandas/cudf discrepancies.Usage example
Dask cuDF should now be using dask-expr for "query planning":
TODO
Follow Up Work: