Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Correct performance regression with 0.7 groupby. #1689

Merged

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented May 9, 2019

An O(N^2) replacement operation was easily replicated with a cpp level replace. Thanks @shwina for your help!

Fixes #1685

@thomcom thomcom requested a review from a team as a code owner May 9, 2019 03:16
@harrism
Copy link
Member

harrism commented May 9, 2019

Can you give us an idea of the performance difference between this, before this, and 0.6?

@thomcom
Copy link
Contributor Author

thomcom commented May 9, 2019

This was the performance on branch-0.7 without the optimization:

https://www.dropbox.com/s/hvjfmifulpgmeny/Screenshot%202019-05-08%2022.55.56.png?raw=1

This is the performance now with the optimization:

https://www.dropbox.com/s/gawyiy5sd7dp0wy/Screenshot%202019-05-08%2023.04.40.png?raw=1

I can't check branch-0.6 at this time because I have other branches that I'm updating. Moving back to branch-0.6 could put me in a build unstable state for hours.

@jrhemstad
Copy link
Contributor

It's wild that this could be done in 3 lines of code.

@raydouglass raydouglass merged commit 862b187 into rapidsai:branch-0.7 May 9, 2019
@harrism
Copy link
Member

harrism commented May 9, 2019

100x, not bad.

@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants