Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add Python 3.7 support, update to gcc5+ ABI, update dependencies: pyarrow=0.11.1, pandas>=0.23.4, cython>=0.29 #668

Merged
merged 32 commits into from
Jan 24, 2019

Conversation

kkraus14
Copy link
Collaborator

@kkraus14 kkraus14 commented Jan 10, 2019

NOTE: @raydouglass or @mike-wendt should merge this once the CI build matrix is ready to be updated based on this as this will break conda Python 3.5 compatibility.

Changes made in this PR:

  • Adds Python 3.7 support, drops Python 3.5 support (not officially, but for now since CI is pretty tied to conda currently)
  • Updates dependency versions: PyArrow=0.11.1, Pandas>=0.23.4, Cython>=0.29
  • Resolves all test errors and warnings related to Python and dependency upgrades

@mike-wendt
Copy link
Contributor

rerun tests

@mike-wendt
Copy link
Contributor

@kkraus14

conda.exceptions.UnsatisfiableError: The following specifications were found to be in conflict:
- pyarrow=0.10 -> arrow-cpp=0.10.0 -> python[version='>=2.7,<2.8.0a0'] -> readline=6.2
- pyarrow=0.10 -> arrow-cpp=0.10.0 -> python[version='>=2.7,<2.8.0a0'] -> sqlite=3.13
- pyarrow=0.10 -> arrow-cpp=0.10.0 -> python[version='>=2.7,<2.8.0a0'] -> tk=8.5
- python=3.7

https://gpuci.gpuopenanalytics.com/job/jarvis/job/cudf/job/cudf-cpu-build/3233/consoleFull#L2,590

@mike-wendt
Copy link
Contributor

pyarrow 0.11 has support for py37 but not 0.10

@kkraus14 kkraus14 added the 2 - In Progress Currently a work in progress label Jan 11, 2019
@kkraus14
Copy link
Collaborator Author

There's no Pandas 0.20.* builds for Python 3.7 so looks like we'll need to update that for this PR as well 🙃

Keith Kraus and others added 2 commits January 11, 2019 17:44
… bump python version to newer than 3.6 in dev environment, remove numba dev label
@mike-wendt
Copy link
Contributor

@kkraus14 building a py37 version of nvstrings for you now to help with this

@raydouglass
Copy link
Member

There is a py37 release of nvstrings now.

@kkraus14
Copy link
Collaborator Author

There is a py37 release of nvstrings now.

Did it remove the Pandas versioning requirement?

@raydouglass
Copy link
Member

Did it remove the Pandas versioning requirement?

Yes, there is no dependency on numba or pandas now. New version is 0.2.0

@mike-wendt
Copy link
Contributor

UnsatisfiableError: The following specifications were found to be in conflict:
  - parquet-cpp -> arrow-cpp[version='>=0.9.0,<0.10.0a0'] -> libboost[version='>=1.65.1,<1.65.2.0a0']
  - pyarrow=0.11.1 -> arrow-cpp[version='>=0.11.1,<0.12.0a0']
Use "conda info <package>" to see the dependencies for each package.

will see if there is a way to fix this

@mike-wendt mike-wendt self-requested a review January 15, 2019 06:18
@mike-wendt
Copy link
Contributor

rerun tests

1 similar comment
@kkraus14
Copy link
Collaborator Author

rerun tests

@randerzander
Copy link
Contributor

fixes #118

Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor CXX11ABI suggestion.

cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@kkraus14 kkraus14 dismissed harrism’s stale review January 22, 2019 18:56

Addressed changes

@kkraus14 kkraus14 changed the title [WIP] Add Python 3.7 support, update to gcc5+ ABI, update dependencies: pyarrow=0.11.1, pandas>=0.23.4, cython>=0.29 [REVIEW] Add Python 3.7 support, update to gcc5+ ABI, update dependencies: pyarrow=0.11.1, pandas>=0.23.4, cython>=0.29 Jan 22, 2019
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currently a work in progress labels Jan 22, 2019
mike-wendt added a commit to rapidsai/gpuci-build-environment that referenced this pull request Jan 23, 2019
@mike-wendt
Copy link
Contributor

rerun tests

@mike-wendt
Copy link
Contributor

@kkraus14 as long as CI passes I'm nearly ready to merge. What I see missing though is an update to the README.md that explains the new flag and how to use it. Do you have anyone that can add that?

cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@kkraus14
Copy link
Collaborator Author

@kkraus14 as long as CI passes I'm nearly ready to merge. What I see missing though is an update to the README.md that explains the new flag and how to use it. Do you have anyone that can add that?

README updated, let me know if it needs changes.

Clarifies ABI flag
Updates references to python 3.6/3.7
@mike-wendt mike-wendt added 0 - Waiting on Author Waiting for author to respond to review and removed 5 - Ready to Merge Testing and reviews complete, ready to merge labels Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Waiting on Author Waiting for author to respond to review CMake CMake build issue Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants