-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add Python 3.7 support, update to gcc5+ ABI, update dependencies: pyarrow=0.11.1, pandas>=0.23.4, cython>=0.29 #668
Conversation
rerun tests |
https://gpuci.gpuopenanalytics.com/job/jarvis/job/cudf/job/cudf-cpu-build/3233/consoleFull#L2,590 |
pyarrow 0.11 has support for py37 but not 0.10 |
There's no Pandas 0.20.* builds for Python 3.7 so looks like we'll need to update that for this PR as well 🙃 |
… bump python version to newer than 3.6 in dev environment, remove numba dev label
@kkraus14 building a py37 version of nvstrings for you now to help with this |
There is a py37 release of nvstrings now. |
Did it remove the Pandas versioning requirement? |
Yes, there is no dependency on numba or pandas now. New version is 0.2.0 |
will see if there is a way to fix this |
rerun tests |
1 similar comment
rerun tests |
fixes #118 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor CXX11ABI suggestion.
rerun tests |
@kkraus14 as long as CI passes I'm nearly ready to merge. What I see missing though is an update to the |
README updated, let me know if it needs changes. |
Clarifies ABI flag Updates references to python 3.6/3.7
NOTE: @raydouglass or @mike-wendt should merge this once the CI build matrix is ready to be updated based on this as this will break conda Python 3.5 compatibility.
Changes made in this PR: