[gpuCI] Auto-merge branch-0.17 to branch-0.18 [skip ci] #6896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #6530 Changes: - Added a method of specifying the nullability of list columns. The API change is as follows: `table_metadata_with_nullability.column_nullable[i]` used to be the nullability of column[i]. Now it contains the flattened nullability of the table e.g. for a table of three columns, `int, list<double>, float`, the nullability vector contains the values: |Index|Nullability of| |-|-| |0|int column| |1|Level 0 of list column (list itself)| |2|Level 1 of list column (double values)| |3|float column| - Modified the method of checking schema across `write_chunk()` calls. Now the entire schema vector is compared rather than just types. - Fixed a bug introduced in list writing PR where a non-nested column following a list column would have the wrong value of definition bits. Now all such cases where the information was being queried from schema have been fixed to use `parquet_column_view` - Fixed a regression introduced in a later commit in list writing PR while adding column_view with offset support to list columns. Changed pinned memory to normal pageable memory. - Added missing tests for chunked writer where the nullability is mismatched across calls, or nullability is specified in first call. Authors: - Devavret Makkar <dmakkar@nvidia.com> - Devavret Makkar <devavret@users.noreply.github.com> Approvers: - Vukasin Milovanovic - Keith Kraus - Mark Harris URL: #6831
GPUtester
requested review from
harrism,
davidwendt,
trxcllnt and
brandon-b-miller
|
SUCCESS - Auto-merge complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-merge triggered by push to
branch-0.17that creates a PR to keepbranch-0.18up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.